* [PATCH] Modify description file to say what this file is
@ 2009-02-17 8:49 John Tapsell
0 siblings, 0 replies; 2+ messages in thread
From: John Tapsell @ 2009-02-17 8:49 UTC (permalink / raw)
To: Git Mailing List
Hi all,
I'm new to git development, and want to make a series of commits to
make git a bit easier to use. This is my first patch, to see how it
goes :-)
>From 60bf1fd524410479fbc30eb67d32689c1297892e Mon Sep 17 00:00:00 2001
From: John Tapsell <johnflux@gmail.com>
Date: Tue, 17 Feb 2009 08:26:28 +0000
Subject: [PATCH] Modify description file to say what this file is
A lot of people see this message for the first time on the gitweb
interface, where there is no clue as to what 'this file' means.
Signed-off-by: John Tapsell <johnflux@gmail.com>
---
templates/hooks--update.sample | 5 +++--
templates/this--description | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/templates/hooks--update.sample b/templates/hooks--update.sample
index 93c6055..f753d28 100755
--- a/templates/hooks--update.sample
+++ b/templates/hooks--update.sample
@@ -43,10 +43,11 @@ allowdeletetag=$(git config --bool hooks.allowdeletetag)
# check for no description
projectdesc=$(sed -e '1q' "$GIT_DIR/description")
-if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit
this file to name it for gitweb." ]; then
+case $projectdesc in "Unnamed repository;"*|'')
echo "*** Project description file hasn't been set" >&2
exit 1
-fi
+ ;;
+esac
# --- Check types
# if $newrev is 0000...0000, it's a commit to delete a ref.
diff --git a/templates/this--description b/templates/this--description
index c6f25e8..914a64e 100644
--- a/templates/this--description
+++ b/templates/this--description
@@ -1 +1 @@
-Unnamed repository; edit this file to name it for gitweb.
+Unnamed repository; edit the .git/description file to name it for gitweb.
--
1.6.2.rc1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Modify description file to say what this file is
@ 2009-02-17 8:58 John Tapsell
0 siblings, 0 replies; 2+ messages in thread
From: John Tapsell @ 2009-02-17 8:58 UTC (permalink / raw)
To: git
A lot of people see this message for the first time on the gitweb
interface, where there is no clue as to what 'this file' means.
Signed-off-by: John Tapsell <johnflux@gmail.com>
---
templates/hooks--update.sample | 5 +++--
templates/this--description | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/templates/hooks--update.sample b/templates/hooks--update.sample
index 93c6055..f753d28 100755
--- a/templates/hooks--update.sample
+++ b/templates/hooks--update.sample
@@ -43,10 +43,11 @@ allowdeletetag=$(git config --bool hooks.allowdeletetag)
# check for no description
projectdesc=$(sed -e '1q' "$GIT_DIR/description")
-if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit
this file to name it for gitweb." ]; then
+case $projectdesc in "Unnamed repository;"*|'')
echo "*** Project description file hasn't been set" >&2
exit 1
-fi
+ ;;
+esac
# --- Check types
# if $newrev is 0000...0000, it's a commit to delete a ref.
diff --git a/templates/this--description b/templates/this--description
index c6f25e8..914a64e 100644
--- a/templates/this--description
+++ b/templates/this--description
@@ -1 +1 @@
-Unnamed repository; edit this file to name it for gitweb.
+Unnamed repository; edit the .git/description file to name it for gitweb.
--
1.6.2.rc1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-17 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-17 8:58 [PATCH] Modify description file to say what this file is John Tapsell
-- strict thread matches above, loose matches on Subject: below --
2009-02-17 8:49 John Tapsell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).