Re: asciidoc, was Re: Chicken/egg problem building from a 'git clone'

[John Tapsell <johnflux@gmail.com>]

2009/3/6 Jakub Narebski <jnareb@gmail.com>:
> On Fri, 6 March 2009, John Tapsell wrote:
>> 2009/3/6 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
>>> On Fri, 6 Mar 2009, John Tapsell wrote:
>>>> 2009/3/6 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
>>>>> On Fri, 6 Mar 2009, Jakub Narebski wrote:
>
>>>>>> However while toolchain needed to produce documentation (asciidoc +
>>>>>> xmlto) isn't, I think, something very common, in my opinion autoconf is
>>>>>> something that is present on systems containing other build tools
>>>>>> required to build git from sources.  So 'configure' branch is not, I
>>>>>> think, as necessary as 'html' and 'man' branches; additionally 'html'
>>>>>> branch (or the repository used to build documentation, or the byproduct
>>>>>> of building documentation) is used to generate on-line docs for git.
>>>>>
>>>>> Plus, keep in mind that autoconf support is only an afterthought in Git;
>>>>> Just running "make" is supposed to work.  If it does not, patches are
>>>>> certainly welcome, I think.
>>>>
>>>> Well now that you mention it.. :-)
>>>>
>>>> It doesn't check for the existance of asciidoc, but blindly assumes it
>>>> exists.  And even if you do have asciidoc, there's a good chance that
>>>> you have the wrong version.   The INSTALL file says that asciidoc
>>>> requires 8.2.7 but most distros (debian, ubuntu.  probably other) have
>>>> 8.2.6.
>
> Do you mean here Makefile checks, or do you mean ./configure checking
> for existing asciidoc toolchain, and for asciidoc version?

Well presumably both would have to check, since you can run make
without configure.  I just figured starting with configure would be
easiest.

>
>>>> If you compile the docs with the wrong asciidoc version, there is no
>>>> warning or error at all.  It just builds incorrect man pages.
>>>
>>> Frankly, I was talking about "make".  I never needed asciidoc there.
>>>
>>> Besides, if it is really an itch of yours, maybe you can come up with a
>>> patch checking for a correct asciidoc version?  Only if asciidoc would be
>>> needed at all, of course.
>>
>> Yep.  I've been looking at it for the last half hour, but configure.ac
>> syntax defeats me :-D   (I figured getting the check into configure.ac
>> would be a good first start)
>
> Errr... doesn't configure.ac have checking for asciidoc version? Search
> for AC_CHECK_PROGS(ASCIIDOC, [asciidoc]). Perhaps tests should be more
> detailed, or something...

Yeah I saw that - it checks if you have version 7.* or 8.*. I just
don't know how to check if the version is >= .8.2.7.

John