From: John Tapsell <johnflux@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Pieter de Bie <pdebie@ai.rug.nl>,
Sverre Rabbelier <srabbelier@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git List <git@vger.kernel.org>
Subject: Re: git checkout -b origin/mybranch origin/mybranch
Date: Thu, 12 Mar 2009 16:45:21 +0000 [thread overview]
Message-ID: <43d8ce650903120945h7063e7baraa3911d2cf63d1d8@mail.gmail.com> (raw)
In-Reply-To: <20090312163533.GA28205@coredump.intra.peff.net>
2009/3/12 Jeff King <peff@peff.net>:
> On Thu, Mar 12, 2009 at 04:16:09PM +0000, John Tapsell wrote:
>
>> I was thinking more along the lines of checking if it begins with
>> remotes/, origin/, tags/, stash/, bisect/ and blacklisting these.
>>
>> Can anyone suggest a reason that you really might want to create a
>> branch called origin/something ?
>
> The name "origin" is simply convention. So if you are thinking about
> blacklisting "origin/*", then it is certainly possible to have a false
> positive (although as you note, it is unlikely). But what is worse is
> that it is very likely for you to have a false negative if you use a
> different remote name (and people often do if they have multiple
> remotes).
>
> For example, in one of my projects where I do integration, "origin" is
> my own public repo, and I have a remote pointing to the public repo of a
> number of other developers from whom I pull. So I would encounter the
> same error by doing:
>
> git checkout -b mike/master mike/master
>
> but it would not be caught by your rule.
>
> One area where your rule _is_ nicer than mine is that mine only looks at
> what exists _now_ and doesn't future-proof you at all. So I could say
>
> git checkout -b origin/newtopic
>
> which might not be ambiguous. But if the remote adds a "newtopic"
> branch, then the next time I fetch it will _become_ ambiguous.
>
> Potentially you could blacklist "X/*" for every remote.X.* that
> exists in your config. Even that, of course, isn't future-proof against
> you creating a new remote. :)
>
> I think the future-proofing is probably not worth the effort. Catching
> things that are ambiguous _now_ will cover the "oops, I typed the wrong
> thing" case, which I think is really the issue.
Yep, makes sense.
I suppose you could do both. Blacklist and check if it already
exists, but I think just checking if it exists is "good enough".
John
next prev parent reply other threads:[~2009-03-12 16:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 11:36 git checkout -b origin/mybranch origin/mybranch John Tapsell
2009-03-12 11:40 ` Sverre Rabbelier
2009-03-12 11:43 ` Johannes Schindelin
2009-03-12 11:48 ` John Tapsell
2009-03-12 13:02 ` Johannes Schindelin
2009-03-12 13:18 ` John Tapsell
2009-03-12 13:43 ` Sverre Rabbelier
2009-03-12 14:14 ` John Tapsell
2009-03-13 14:08 ` Michael J Gruber
2009-03-12 15:21 ` Pieter de Bie
2009-03-12 15:37 ` Jeff King
2009-03-12 16:16 ` John Tapsell
2009-03-12 16:35 ` Jeff King
2009-03-12 16:40 ` Pieter de Bie
2009-03-12 16:51 ` Jeff King
2009-03-12 16:58 ` John Tapsell
2009-03-12 17:14 ` Jeff King
2009-03-12 17:45 ` John Tapsell
2009-03-12 16:45 ` John Tapsell [this message]
2009-03-12 18:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43d8ce650903120945h7063e7baraa3911d2cf63d1d8@mail.gmail.com \
--to=johnflux@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pdebie@ai.rug.nl \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).