git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Vilain <sam@vilain.net>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: bug?: stgit creates (unneccessary?) conflicts when pulling
Date: Tue, 28 Feb 2006 10:45:34 +1300	[thread overview]
Message-ID: <440372FE.2000301@vilain.net> (raw)
In-Reply-To: <20060227204252.GA31836@diana.vm.bytemark.co.uk>

Karl Hasselström wrote:
> If I make a patch series where more than one patch touches the same
> line, I get a lot of merge errors when upstream has accepted them and
> I try to merge them back.
> 
> Suppose a line contained the string "0". Patch p1 changes that to "1",
> patch p2 further changes that to "2". Upstream accept the patches, and
> I later "stg pull" them. When reapplying p1 after the pull, stg
> generates a merge conflict since upstream changed the "0" to "2" and
> p1 changes the "0" to "1".
> 
> This situation arises for every line that's modified in more than one
> patch, and for every such patch except the last one. And it's really
> annoying, since it's intuitively obvious that there aren't actually
> any conflicts, since upstream accepted my patches verbatim.
> 
> I suppose one way to fix it manually would be to first fetch, glance
> at the new upstream commits and try to find any accepted patches, and
> then "stg pull" the commit corresponding to the earliest patch in my
> series; repeat for every patch in the series. The queston is, how can
> we automate it?

I don't seem to suffer from this, using my "diff3 || 
ediff-merge-files-with-ancestor" script as a merge tool.  The diff3, or 
ediff, seem to DTRT so long as the change is cleanly applied.  Otherwise 
I just get a merge conflict difference and I just press A/B to pick 
which one I want.

Sam.

  reply	other threads:[~2006-02-27 21:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-27 20:42 bug?: stgit creates (unneccessary?) conflicts when pulling Karl Hasselström
2006-02-27 21:45 ` Sam Vilain [this message]
2006-02-27 22:17 ` Catalin Marinas
2006-02-28 15:00   ` Catalin Marinas
2006-02-28 18:53     ` Catalin Marinas
2006-02-28 22:45   ` Catalin Marinas
2006-03-01 17:39     ` Chuck Lever
2006-03-01 17:53       ` Catalin Marinas
2006-03-03 14:13         ` Karl Hasselström
2006-03-03 21:57           ` Catalin Marinas
2006-03-03 14:24     ` Karl Hasselström
2006-03-03 22:07       ` Catalin Marinas
2006-02-27 22:26 ` Shawn Pearce
2006-03-01 10:59   ` Catalin Marinas
2006-03-01 14:51     ` Shawn Pearce
2006-03-01 15:08       ` Catalin Marinas
2006-03-01 15:50         ` Shawn Pearce
2006-03-09 22:00           ` Catalin Marinas
2006-03-09 23:20             ` Junio C Hamano
2006-03-10 11:13               ` Catalin Marinas
2006-03-11  6:46                 ` Junio C Hamano
2006-03-10 16:23             ` Shawn Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440372FE.2000301@vilain.net \
    --to=sam@vilain.net \
    --cc=catalin.marinas@arm.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).