From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Josh Soref" <gitgitgadget@gmail.com>, git@vger.kernel.org
Cc: Alex <alexguo1023@gmail.com>, jinyaoguo <guo846@purdue.edu>
Subject: Re: [PATCH] Fix memory leak in function handle_content_type
Date: Fri, 13 Jun 2025 18:59:48 +0200 [thread overview]
Message-ID: <44066126-ece9-4c77-b38a-292b6f748955@app.fastmail.com> (raw)
In-Reply-To: <pull.1997.git.git.1749833577767.gitgitgadget@gmail.com>
On Fri, Jun 13, 2025, at 18:52, Alex via GitGitGadget wrote:
> From: jinyaoguo <guo846@purdue.edu>
>
> [snip]
>
> Signed-off-by: Alex Guo <alexguo1023@gmail.com>
Like what was said on another patch[1] the From and Signed-off-by names
need to match. I didn’t see a resolution to that?
If forwarding you need to add your signoff after theirs.
[1]: https://lore.kernel.org/git/xmqq1psfxgyv.fsf@gitster.g/
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2025-06-13 17:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 16:52 [PATCH] Fix memory leak in function handle_content_type Alex via GitGitGadget
2025-06-13 16:59 ` Kristoffer Haugsbakk [this message]
2025-06-13 18:36 ` Jinyao Guo
2025-06-13 19:06 ` Junio C Hamano
2025-06-13 19:26 ` Jinyao Guo
2025-06-14 16:45 ` Junio C Hamano
2025-06-15 12:55 ` Lidong Yan
2025-06-16 1:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44066126-ece9-4c77-b38a-292b6f748955@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=alexguo1023@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=guo846@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox