git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ryan Anderson <ryan@michonline.com>
To: Fredrik Kuivinen <freku045@student.liu.se>
Cc: git@vger.kernel.org, junkio@cox.net
Subject: Re: [PATCH] git-blame: Use the same tests for git-blame as for git-annotate
Date: Sun, 05 Mar 2006 21:56:26 -0500	[thread overview]
Message-ID: <440BA4DA.9060101@michonline.com> (raw)
In-Reply-To: <20060305111334.GB23448@c165.ib.student.liu.se>

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

Fredrik Kuivinen wrote:

>Signed-off-by: Fredrik Kuivinen <freku045@student.liu.se>
>
>
>---
>
> t/annotate-tests.sh |   86 +++++++++++++++++++++++++++++++++++++++++++++++++++
> t/t8001-annotate.sh |   85 +-------------------------------------------------
> t/t8002-blame.sh    |    9 +++++
> 3 files changed, 97 insertions(+), 83 deletions(-)
> create mode 100644 t/annotate-tests.sh
> create mode 100755 t/t8002-blame.sh
>
>06b0e500a5202899dcfd037cf78ee4a982da46b4
>diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
>new file mode 100644
>index 0000000..54a4dfb
>--- /dev/null
>+++ b/t/annotate-tests.sh
>@@ -0,0 +1,86 @@
>+# This file isn't used as a test script directly, instead it is
>+# sourced from t8001-annotate.sh and t8001-blame.sh.
>+
>+test_expect_success \
>+    'prepare reference tree' \
>+    'echo "1A quick brown fox jumps over the" >file &&
>+     echo "lazy dog" >>file &&
>+     git add file
>+     GIT_AUTHOR_NAME="A" git commit -a -m "Initial."'
>+
>+test_expect_success \
>+    'check all lines blamed on A' \
>+    '[ $(git annotate file | awk "{print \$3}" | grep -c "A") == 2 ]'
>  
>
This should be $PROG as well, I suspect.

Also, we need to agree on a syntax for working on non-HEAD revisions.

"git annotate $file $commitish" is what I had been using, but it's
really not something I feel strongly about.


-- 

Ryan Anderson
  sometimes Pug Majere


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

  parent reply	other threads:[~2006-03-06  2:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-05 11:13 [PATCH] git-blame: Use the same tests for git-blame as for git-annotate Fredrik Kuivinen
2006-03-05 23:32 ` Ryan Anderson
2006-03-06  0:19   ` Junio C Hamano
2006-03-06  0:29   ` Martin Langhoff
2006-03-06  2:43     ` [PATCH] annotate: Support annotation of files on other revisions Ryan Anderson
2006-03-06  4:18       ` Martin Langhoff
2006-03-06  7:49         ` Fredrik Kuivinen
2006-03-06  5:31       ` A Large Angry SCM
2006-03-06  5:40         ` Ryan Anderson
2006-03-06  5:50           ` Shawn Pearce
2006-03-06  6:16             ` Junio C Hamano
2006-03-06  6:32               ` Shawn Pearce
2006-03-06  6:21             ` A Large Angry SCM
2006-03-06  6:28               ` Junio C Hamano
2006-03-06  9:24                 ` Johannes Schindelin
2006-03-06  9:18       ` Johannes Schindelin
2006-03-06 15:44         ` Ryan Anderson
2006-03-06  2:56 ` Ryan Anderson [this message]
2006-03-06  6:12   ` [PATCH] annotate/blame tests updates Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440BA4DA.9060101@michonline.com \
    --to=ryan@michonline.com \
    --cc=freku045@student.liu.se \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).