From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Ericsson Subject: Re: Pulling tags from git.git Date: Tue, 07 Mar 2006 16:35:09 +0100 Message-ID: <440DA82D.3060909@op5.se> References: <4dd15d180603061044h3f70d48bk8006c15e605fdca1@mail.gmail.com> <4dd15d180603061054k36d1a434se7377ded1b3240bb@mail.gmail.com> <440D5285.3050401@op5.se> <7voe0ilf25.fsf@assigned-by-dhcp.cox.net> <440D7A7D.8070507@op5.se> <440D9AB0.4070305@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Junio C Hamano , git@vger.kernel.org X-From: git-owner@vger.kernel.org Tue Mar 07 16:36:20 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FGeE2-0004Fk-Vu for gcvg-git@gmane.org; Tue, 07 Mar 2006 16:35:51 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751224AbWCGPfM (ORCPT ); Tue, 7 Mar 2006 10:35:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751237AbWCGPfM (ORCPT ); Tue, 7 Mar 2006 10:35:12 -0500 Received: from linux-server1.op5.se ([193.201.96.2]:444 "EHLO smtp-gw1.op5.se") by vger.kernel.org with ESMTP id S1751224AbWCGPfL (ORCPT ); Tue, 7 Mar 2006 10:35:11 -0500 Received: from [192.168.1.20] (host-213.88.215.14.addr.se.sn.net [213.88.215.14]) by smtp-gw1.op5.se (Postfix) with ESMTP id BCA846BD1E; Tue, 7 Mar 2006 16:35:09 +0100 (CET) User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929) X-Accept-Language: en-us, en To: gitzilla@gmail.com In-Reply-To: <440D9AB0.4070305@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: A Large Angry SCM wrote: > Andreas Ericsson wrote: > >> Junio C Hamano wrote: >> >>> Andreas Ericsson writes: >>> >>> >>>> With the git or git+ssh protocol, tags will be autofollowed >>>> when you do a pull (only signed tags, I think). The >>>> auto-following is done by detecting tags that are fetched, >>> >>> >>> >>> Ah, you are correct. We do not follow lightweight tags; I am >>> not sure if we should. >>> >> >> I'm fairly sure we shouldn't. The default update-hook prevents them >> (if enabled), and I can't for the life of me think of why anyone would >> want to distribute such tags. >> >> OTOH, preventing unannotated tags from being pushed seems like a >> better way than to not have the ability to auto-follow those same >> tags. After all, it's better to discourage than to disallow. >> > > Before you do this, please explain why unannotated tags are not useful, > and so should not be allowed to be pushed. Imagine Linus, getting his "please pull" emails and doing so only to find dozens of temporary tags fetched by the pull. Junio's patch (if I read it correctly) unconditionally fetches *ALL* tags reachable from the top of the commit-chain, which means there is no longer any way to keep temporary tags in a repo from which someone else will pull. I for one riddle my repos with temporary tags whenever I'm trying something I'm not so sure of, or find an interesting bug or a design decision I'm not 100% sure of. Perhaps I should rather do this with branches, but imo branches are for doing work, whereas tags just mark a spot in the development so I easily can find them with gitk or some such. I may be biased by the way we do things at work. In our workflow, all tags meant to be distributed have a short note in them which explains the rationale of the tag. For example, new versions have a very brief changelog that sales-people get on email (a blessing, that, since we devs no longer have to update feature-lists and such). Tags not meant to be distributed are unannotated, and unannotated tags are kept out of published repos which are always stored at a central server. Everybody synchronize to those central repos, so nobody pulls from each other. Perhaps this is how the kernel devs work too, but if it ever changes the update hook will no longer be able to safeguard from it and the, in my eyes, temporary tags will be distributed in a criss-crossing mesh so no-one will ever know where it came from or who created it or why. I.e. a Bad Thing. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231