* [PATCH v2] git-check-ref-format: clarify man for --normalize
@ 2017-02-19 22:32 Damien Regad
2017-02-20 0:47 ` Jeff King
0 siblings, 1 reply; 3+ messages in thread
From: Damien Regad @ 2017-02-19 22:32 UTC (permalink / raw)
To: git; +Cc: Philip Oakley, Jeff King, Michael Haggerty
Use of 'iff' may be confusing to people not familiar with this term.
Improving the --normalize option's documentation to remove the use of
'iff', and clearly describe what happens when the condition is not met.
---
Documentation/git-check-ref-format.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-check-ref-format.txt
b/Documentation/git-check-ref-format.txt
index 8611a99..92777ce 100644
--- a/Documentation/git-check-ref-format.txt
+++ b/Documentation/git-check-ref-format.txt
@@ -100,10 +100,10 @@ OPTIONS
--normalize::
Normalize 'refname' by removing any leading slash (`/`)
characters and collapsing runs of adjacent slashes between
- name components into a single slash. Iff the normalized
+ name components into a single slash. If the normalized
refname is valid then print it to standard output and exit
- with a status of 0. (`--print` is a deprecated way to spell
- `--normalize`.)
+ with a status of 0, otherwise exit with a non-zero status.
+ (`--print` is a deprecated way to spell `--normalize`.)
EXAMPLES
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] git-check-ref-format: clarify man for --normalize
2017-02-19 22:32 [PATCH v2] git-check-ref-format: clarify man for --normalize Damien Regad
@ 2017-02-20 0:47 ` Jeff King
2017-02-20 9:10 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jeff King @ 2017-02-20 0:47 UTC (permalink / raw)
To: Damien Regad; +Cc: git, Philip Oakley, Michael Haggerty
On Sun, Feb 19, 2017 at 11:32:32PM +0100, Damien Regad wrote:
> Use of 'iff' may be confusing to people not familiar with this term.
>
> Improving the --normalize option's documentation to remove the use of
> 'iff', and clearly describe what happens when the condition is not met.
Looks good to me. Thanks for following up.
-Peff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] git-check-ref-format: clarify man for --normalize
2017-02-20 0:47 ` Jeff King
@ 2017-02-20 9:10 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2017-02-20 9:10 UTC (permalink / raw)
To: Jeff King; +Cc: Damien Regad, git, Philip Oakley, Michael Haggerty
Jeff King <peff@peff.net> writes:
> On Sun, Feb 19, 2017 at 11:32:32PM +0100, Damien Regad wrote:
>
>> Use of 'iff' may be confusing to people not familiar with this term.
>>
>> Improving the --normalize option's documentation to remove the use of
>> 'iff', and clearly describe what happens when the condition is not met.
>
> Looks good to me. Thanks for following up.
Looks good except that there does not seem to be sign-off.
Damien, no need to resend the patch but I need to hear you say that
you have read Documentation/SubmittingPatches and you want your
sign-off added.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-20 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-19 22:32 [PATCH v2] git-check-ref-format: clarify man for --normalize Damien Regad
2017-02-20 0:47 ` Jeff King
2017-02-20 9:10 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).