From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Peter Eriksen <s022018@student.dtu.dk>, git@vger.kernel.org
Subject: Re: [PATCH] Solaris needs strings.h when using index().
Date: Tue, 04 Apr 2006 11:44:29 -0700 [thread overview]
Message-ID: <4432BE8D.3030504@zytor.com> (raw)
In-Reply-To: <7vwte56w7n.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> "Peter Eriksen" <s022018@student.dtu.dk> writes:
>
>> From: Peter Eriksen <s022018@student.dtu.dk>
>> Date: Tue Apr 4 14:33:14 2006 +0200
>> Subject: [PATCH] Solaris needs strings.h when using index().
>>
>> Signed-off-by: Peter Eriksen <s022018@student.dtu.dk>
>
> I think somebody else noticed this the other day but I'm
> undecided if it is easier to replace use of index with strchr,
> since we include <string.h> and use strchr() everywhere.
>
strchr() is definitely more portable. The further away you get from BSD
heritage, the less likely it is that you're going to see bzero, index,
et al whereas anything even remotely modern has memset, strchr, etc.
-hpa
prev parent reply other threads:[~2006-04-04 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-04 12:36 [PATCH] Solaris needs strings.h when using index() Peter Eriksen
2006-04-04 18:18 ` Junio C Hamano
2006-04-04 18:44 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4432BE8D.3030504@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=s022018@student.dtu.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).