From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Christoph Grüninger" <foss@grueninger.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] [ci] Update GitHub Actions to latest major release / GitHub #2278
Date: Sat, 25 Apr 2026 12:22:16 +0200 (CEST) [thread overview]
Message-ID: <44549a1f-d5e5-fb2b-bebb-a7fa05e10076@gmx.de> (raw)
In-Reply-To: <b3238847-91c1-42fa-b87a-b9d10daa6066@grueninger.de>
[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]
Hi Christoph,
On Sat, 25 Apr 2026, Christoph Grüninger wrote:
> I repost my suggested contribution from:
>
> https://github.com/git/git/pull/2278
>
> I updated all GitHub Actions to their latest major release. In contrast
> to "ci: GitHub Actions updates" (brought to you by Dependabot
> (https://lore.kernel.org/git/pull.2097.git.1776775319.gitgitgadget@gmail.com/T/#t),
> I update some more standard actions and mshick/add-pr-comment.
> They fix deprecation warnings that GitHub Action deprecated Node20.js.
Sorry, I was unclear in my suggestion at
https://github.com/git/git/pull/2278#issuecomment-4302349600: I did not
mean to just throw out a diverging patch. What I meant was to analyze what
the differences are, and to work toward a combined, improved contribution
that is better than either of the original ones.
Lucky for me, it is easy to compare the contributions via:
https://github.com/dscho/git/compare/dependabot-updates..gruenich:git:feature/update-github-actions
This diff shows that I had missed an update of the `mshick/add-pr-comment`
Action from v2 to v3. Or, more correctly, Dependabot had not yet reported
this in `git-for-windows/git`...
I will add a patch to my patch series, crediting you with the find.
Ciao,
Johannes
next prev parent reply other threads:[~2026-04-25 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 14:20 [PATCH] [ci] Update GitHub Actions to latest major release / GitHub #2278 Christoph Grüninger
2026-04-25 10:22 ` Johannes Schindelin [this message]
2026-04-25 10:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44549a1f-d5e5-fb2b-bebb-a7fa05e10076@gmx.de \
--to=johannes.schindelin@gmx.de \
--cc=foss@grueninger.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox