From: Thomas Rast <trast@student.ethz.ch>
To: <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Jonathan Nieder <jrnieder@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: [PATCH 3/3] t/lib-terminal: test test-terminal's sanity
Date: Mon, 12 Dec 2011 19:09:15 +0100 [thread overview]
Message-ID: <44602402ecfd0e49c202f03e87540934aa23bce0.1323713230.git.trast@student.ethz.ch> (raw)
In-Reply-To: <b97d14da67bd6097e5b04f6ae3057c0f1d536a0b.1323713230.git.trast@student.ethz.ch>
The previous two commits show that getting test-terminal.perl right is
not trivial. Let lib-terminal.sh run a simple test that ensures it
actually opens TTYs for std{in,out,err} and that it does not let stdin
pass through.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
t/lib-terminal.sh | 19 +++++++++++++++++++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh
index 58d911d..9e4ff9c 100644
--- a/t/lib-terminal.sh
+++ b/t/lib-terminal.sh
@@ -33,3 +33,22 @@ test_expect_success PERL 'set up terminal for tests' '
}
fi
'
+
+cat >expect1 <<EOF
+stdin: 1
+stdout: 1
+stderr: 1
+EOF
+: >expect2
+
+test_expect_success TTY 'test-terminal.perl is sane' '
+ test_terminal perl -e "
+ use POSIX qw(isatty);
+ print \"stdin: \", isatty(STDIN), \"\\n\";
+ print \"stdout: \", isatty(STDOUT), \"\\n\";
+ print \"stderr: \", isatty(STDERR), \"\\n\";
+ " >actual1 &&
+ test_cmp expect1 actual1 &&
+ echo foo | test_terminal cat - >actual2 &&
+ test_cmp expect2 actual2
+'
--
1.7.8.431.g2abf2
next prev parent reply other threads:[~2011-12-12 18:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 18:09 [PATCH 1/3] test-terminal: give the child an empty stdin TTY Thomas Rast
2011-12-12 18:09 ` [PATCH 2/3] test-terminal: set output terminals to raw mode Thomas Rast
2011-12-12 18:23 ` Jonathan Nieder
2011-12-12 19:01 ` Thomas Rast
2011-12-13 5:09 ` Jonathan Nieder
2011-12-12 18:09 ` Thomas Rast [this message]
2011-12-12 18:25 ` [PATCH 3/3] t/lib-terminal: test test-terminal's sanity Jonathan Nieder
2011-12-12 18:19 ` [PATCH 1/3] test-terminal: give the child an empty stdin TTY Jonathan Nieder
2011-12-12 18:34 ` Thomas Rast
2011-12-12 19:05 ` Jonathan Nieder
2011-12-12 20:06 ` Junio C Hamano
2011-12-12 19:07 ` Junio C Hamano
2011-12-12 19:14 ` Thomas Rast
2011-12-12 19:16 ` Jeff King
2011-12-12 20:38 ` Junio C Hamano
2011-12-12 23:25 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44602402ecfd0e49c202f03e87540934aa23bce0.1323713230.git.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).