git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Björn Engelmann" <BjEngelmann@gmx.de>
To: git@vger.kernel.org
Subject: [PATCH 0/2] tagsize < 8kb restriction
Date: Mon, 22 May 2006 16:48:03 +0200	[thread overview]
Message-ID: <4471CF23.1070807@gmx.de> (raw)

Hi,

I am currently working on an interface for source code quality assurance
tools to automatically scan newly commited code. Since it is the only
way to add data (scan-results) to an already-existing commit, I decided
to use tags for that.

Since the scan-results will most definitly exeed the 8kb-limit, I would
like to remove this artificial restriction.

I know I could also

    git-hash-object -t tag -w

but prefer using the "official" way.


In order not to write duplicate code I used parts of index_pipe() in
sha1_file.c

What I found odd when writing the patch was that main() in mktag.c uses
xread() to read from stdin (which respects EAGAIN and EINTR return
values), but index_pipe() in sha1_file.c just uses read() for doing
merely the same thing. For unifying both routines i found that xread()
might be the better choice.

Removing the restriction was pretty straightforward but do you think
this would break something in other places ?


[PATCH 1/2]
    remove the < 8kb restrinction from git-mktag

[PATCH 2/2]
    add more informative error messages to git-mktag


Bj

             reply	other threads:[~2006-05-22 14:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-22 14:48 Björn Engelmann [this message]
2006-05-22 19:18 ` [PATCH 0/2] tagsize < 8kb restriction Junio C Hamano
     [not found]   ` <20060522191240.1cb8c93f.seanlkml@sympatico.ca>
2006-05-22 23:12     ` Sean
2006-05-23  0:02       ` Linus Torvalds
     [not found]         ` <20060523055900.0dd845fd.seanlkml@sympatico.ca>
2006-05-23  9:59           ` Sean
2006-05-23 20:40   ` Björn Engelmann
2006-05-23 23:15     ` Junio C Hamano
2006-05-24 19:16       ` Björn Engelmann
2006-05-24 19:39         ` Junio C Hamano
2006-05-25 11:53           ` Björn Engelmann
2006-05-25 20:03             ` Junio C Hamano
2006-05-23 23:49     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4471CF23.1070807@gmx.de \
    --to=bjengelmann@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).