From: sf <sf@b-i-t.de>
To: git@vger.kernel.org
Subject: Re: [PATCH] Do not drop data from '\0' until eol in patch output
Date: Fri, 07 Jul 2006 13:18:52 +0200 [thread overview]
Message-ID: <44AE431C.4090509@b-i-t.de> (raw)
In-Reply-To: <7vslld1ycq.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Stephan Feder <sf@b-i-t.de> writes:
>
>> The binary file detection is just a heuristic which can well fail.
>> Do not produce garbage patches in these cases.
>>
>> Signed-off-by: Stephan Feder <sf@b-i-t.de>
>
> Thanks.
>
> I do not think this patch is _wrong_ per se, but I wonder what
> you would use a patch like that for. Specifically, do you apply
> such a patch with NUL and other binary data in it, and if so
> what tool do you use?
>
GNU patch can apply patches with binary content which are typically
produced with GNU diff with --text option.
next prev parent reply other threads:[~2006-07-07 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 10:33 [PATCH] Do not drop data from '\0' until eol in patch output Stephan Feder
2006-07-07 10:52 ` Junio C Hamano
2006-07-07 11:18 ` sf [this message]
2006-07-07 12:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44AE431C.4090509@b-i-t.de \
--to=sf@b-i-t.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).