git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
To: Willy Tarreau <w@1wt.eu>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] tar-tree: add the "tar.applyUmask" config option
Date: Thu, 20 Jul 2006 10:14:02 +0200	[thread overview]
Message-ID: <44BF3B4A.5040109@lsrfire.ath.cx> (raw)
In-Reply-To: <20060719214025.GA10997@1wt.eu>

Hi Willy,

I kind of like the change, because it gives the user more control.
Theoretically this would not be needed, because tar can apply the
umask at extract time just fine.  In practice I can't see why we
should forbid users from creating the archives just the way they
like them, no matter what their reasoning might be.

Willy Tarreau schrieb:
> +tar.applyUmask::
> +	By default, git-link:git-tar-tree[1] sets file and directories modes
> +	to 0666 or 0777. While this is both useful and acceptable for projects
> +	such as the Linux Kernel, it might be excessive for other projects.
> +	Setting this variable to true makes git-link:git-tar-tree[1] apply the
> +	umask to the modes above. This should be enough for most projects, as
> +	it will lead to the same permissions as git-link:git-checkout[1] would
> +	use. The default is false.

Comments about why this change is needed and that it is sufficient
should go into the commit message.  For the rest of the patch:

Acked-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>

  parent reply	other threads:[~2006-07-20  8:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-19 21:40 [PATCH] tar-tree: add the "tar.applyUmask" config option Willy Tarreau
2006-07-19 22:33 ` Junio C Hamano
2006-07-19 22:50   ` Willy Tarreau
2006-07-20  9:30   ` Willy Tarreau
2006-07-20  9:44     ` Rogan Dawes
2006-07-20  9:55       ` Willy Tarreau
2006-07-19 22:39 ` Johannes Schindelin
2006-07-20  8:14 ` Rene Scharfe [this message]
2006-07-24  6:42   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44BF3B4A.5040109@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=torvalds@osdl.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).