From: Rogan Dawes <discard@dawes.za.net>
To: Willy Tarreau <w@1wt.eu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] tar-tree: add the "tar.applyUmask" config option
Date: Thu, 20 Jul 2006 11:44:26 +0200 [thread overview]
Message-ID: <44BF507A.4080801@dawes.za.net> (raw)
In-Reply-To: <20060720093044.GA10824@1wt.eu>
Willy Tarreau wrote:
> +int git_tar_config(const char *var, const char *value)
> +{
> + if (!strcmp(var, "tar.umask")) {
> + if (!strcmp(value, "user")) {
> + tar_umask = umask(0);
> + umask(tar_umask);
> + } else {
> + tar_umask = git_config_int(var, value);
Looks like you forgot:
umask(tar_umask);
> + }
> + return 0;
> + }
> + return git_default_config(var, value);
> +}
Or else move it to just before the "return 0;" line.
Rogan
next prev parent reply other threads:[~2006-07-20 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 21:40 [PATCH] tar-tree: add the "tar.applyUmask" config option Willy Tarreau
2006-07-19 22:33 ` Junio C Hamano
2006-07-19 22:50 ` Willy Tarreau
2006-07-20 9:30 ` Willy Tarreau
2006-07-20 9:44 ` Rogan Dawes [this message]
2006-07-20 9:55 ` Willy Tarreau
2006-07-19 22:39 ` Johannes Schindelin
2006-07-20 8:14 ` Rene Scharfe
2006-07-24 6:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44BF507A.4080801@dawes.za.net \
--to=discard@dawes.za.net \
--cc=git@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).