git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 8/9] git-verify-pack: no need to count errors
Date: Thu, 10 Aug 2006 19:37:18 +0200	[thread overview]
Message-ID: <44DB6ECE.10706@lsrfire.ath.cx> (raw)
In-Reply-To: <Pine.LNX.4.63.0608101822550.10541@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin schrieb:
> there was no harm done counting the errors, i.e. no need to "fix" that.

Yes, it's more of a style thing.  Why count when you don't need the
number?  Why use "!!" when you can use "1" explicitly?

And then there's the danger of counter wrap-around. ;-)

It's surely one of those bikeshed colour issues, admittedly.

Thanks,
René

  reply	other threads:[~2006-08-10 17:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-10 15:02 [PATCH 0/9] git-verify-pack: clean up and make builtin Rene Scharfe
2006-08-10 15:02 ` [PATCH 1/9] Add has_extension() Rene Scharfe
2006-08-10 16:25   ` Johannes Schindelin
2006-08-10 17:48     ` Rene Scharfe
2006-08-10 18:21   ` Fredrik Kuivinen
2006-08-10 18:42     ` Rene Scharfe
2006-08-10 21:47       ` Fredrik Kuivinen
2006-08-10 15:02 ` [PATCH 2/9] git-verify-pack: show usage when no pack was specified Rene Scharfe
2006-08-10 15:02 ` [PATCH 3/9] git-verify-pack: more careful path handling Rene Scharfe
2006-08-10 15:02 ` [PATCH 4/9] git-verify-pack: insist on .idx extension Rene Scharfe
2006-08-10 15:02 ` [PATCH 5/9] git-verify-pack: get rid of while loop Rene Scharfe
2006-08-10 15:02 ` [PATCH 6/9] git-verify-pack: free pack after use and a cleanup Rene Scharfe
2006-08-10 15:02 ` [PATCH 7/9] git-verify-pack: buffer overrun paranoia Rene Scharfe
2006-08-10 15:02 ` [PATCH 8/9] git-verify-pack: no need to count errors Rene Scharfe
2006-08-10 16:23   ` Johannes Schindelin
2006-08-10 17:37     ` Rene Scharfe [this message]
2006-08-10 15:02 ` [PATCH 9/9] git-verify-pack: make builtin Rene Scharfe
2006-08-10 16:24   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44DB6ECE.10706@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).