From: Robert Shearman <rob@codeweavers.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-sh-setup: Fail if the git directory was not found.
Date: Sun, 13 Aug 2006 12:52:36 +0100 [thread overview]
Message-ID: <44DF1284.5080406@codeweavers.com> (raw)
In-Reply-To: <7vlkpuragp.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
>Junio C Hamano <junkio@cox.net> writes:
>
>
>
>>Moving the assignment of GIT_OBJECT_DIRECTORY is fine, but
>>changing it to an unconditional assignment is wrong. The user
>>can have a GIT_OBJECT_DIRECTORY set independently from GIT_DIR
>>(or ../some/where/.git that is detected).
>>
>>
I'm not an expert in shell scripting so I didn't notice that it was a
conditional assignment.
>How about this as a replacement?
>
>
Looks good.
Thanks,
--
Rob Shearman
prev parent reply other threads:[~2006-08-13 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-11 9:23 [PATCH] git-sh-setup: Fail if the git directory was not found Robert Shearman
2006-08-11 19:42 ` Alex Riesen
2006-08-11 22:39 ` Junio C Hamano
2006-08-12 1:47 ` Junio C Hamano
2006-08-13 11:52 ` Robert Shearman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DF1284.5080406@codeweavers.com \
--to=rob@codeweavers.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).