From: "Martin Langhoff (CatalystIT)" <martin@catalyst.net.nz>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-repack: create new packs inside $PACKDIR, not cwd
Date: Mon, 04 Sep 2006 22:46:55 +1200 [thread overview]
Message-ID: <44FC041F.6010002@catalyst.net.nz> (raw)
In-Reply-To: <7vlkp0ndmj.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> "Martin Langhoff (CatalystIT)" <martin@catalyst.net.nz> writes:
>
>
>>BTW, I think there's a small error.
>>
>>Your packtmp includes $$ which means that rm -f "$PACKTMP" will only
>>clear out old packs..
>
>
> That was deliberate. I hate programs that clean things up
> behind user's back. The first "rm" is to get rid of what would
> collide with what we are going to do (i.e. protecting ourselves)
> and "trap rm" is to make sure we do not leave the cruft we know
> we are going to create. I'd rather leave other people's cruft
> around, unless the purpose of the command is to clean things up,
> and repack is hardly that.
>
Ah, ok. I misunderstood the use of trap -- of course, re-reading the man
pages, it makes sense.
A-ok with me, then, and sorry about the noise.
martin
--
-----------------------------------------------------------------------
Martin @ Catalyst .Net .NZ Ltd, PO Box 11-053, Manners St, Wellington
WEB: http://catalyst.net.nz/ PHYS: Level 2, 150-154 Willis St
OFFICE: +64(4)916-7224 MOB: +64(21)364-017
Make things as simple as possible, but no simpler - Einstein
-----------------------------------------------------------------------
--
VGER BF report: H 0.0618878
next prev parent reply other threads:[~2006-09-04 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 5:42 [PATCH] git-repack: create new packs inside $PACKDIR, not cwd Martin Langhoff
2006-09-04 9:08 ` Martin Waitz
2006-09-04 9:36 ` Junio C Hamano
2006-09-04 9:50 ` Junio C Hamano
2006-09-04 10:03 ` Martin Langhoff (CatalystIT)
2006-09-04 10:13 ` Junio C Hamano
2006-09-04 10:46 ` Martin Langhoff (CatalystIT) [this message]
2006-09-04 20:16 ` Junio C Hamano
[not found] <1157337502104-git-send-email-martin@catalyst.net.nz>
2006-09-04 2:42 ` Martin Langhoff (CatalystIT)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FC041F.6010002@catalyst.net.nz \
--to=martin@catalyst.net.nz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).