From: Andy Whitcroft <apw@shadowen.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Teach rev-list an option to read revs from the standard input.
Date: Thu, 07 Sep 2006 09:11:34 +0100 [thread overview]
Message-ID: <44FFD436.4020407@shadowen.org> (raw)
In-Reply-To: <7vhczk5wup.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Andy Whitcroft <apw@shadowen.org> writes:
>
>> Ok, I've tested this with an updated version of my patch to make
>> send-pack use this (which I'll send out following this message) and it
>> seems to work pretty well.
>
> Eh, I have your earlier one placed on "pu" already. I do not
> mind replacing it with the new one but (1) have you checked what
> is in "pu"? (2) how different is this new one compared to it?
There was white space breakage in the patch which I noticed late in the
game, and a problem with the printing lacking newlines. Your conversion
to direct writes on the fd fixes the bug part.
What you have on 'pu' looks good to me.
/me wasn't aware of the meaning of the pu branch :)
-apw
next prev parent reply other threads:[~2006-09-07 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 4:47 [PATCH 2/2] Teach rev-list an option to read revs from the standard input Junio C Hamano
2006-09-06 9:12 ` Jakub Narebski
2006-09-06 12:32 ` Andy Whitcroft
2006-09-06 12:40 ` [PATCH] send pack switch to using git rev list stdin v2 Andy Whitcroft
2006-09-07 0:44 ` [PATCH 2/2] Teach rev-list an option to read revs from the standard input Junio C Hamano
2006-09-07 8:11 ` Andy Whitcroft [this message]
2006-09-07 9:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FFD436.4020407@shadowen.org \
--to=apw@shadowen.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).