git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Franck <vagabon.xyz@gmail.com>,
	git@vger.kernel.org, Rene Scharfe <rene.scharfe@lsrfire.ath.cx>,
	Jakub Narebski <jnareb@gmail.com>
Subject: Add git-archive [take #2]
Date: Thu, 07 Sep 2006 15:08:19 +0200	[thread overview]
Message-ID: <450019C3.4030001@innova-card.com> (raw)
In-Reply-To: <7vr6yo2isu.fsf@assigned-by-dhcp.cox.net>

I'm sending a new version of the patchset which allows 'git-archive'
and 'git-upload-archive' command. I tried to take into account all
feedbacks made by Junio and Rene, but there are still some open points.

  1/ Allow 'git-upload-archive' command to enable/disable some
     formats. This should be done by 'git-upload-archive'.

  2/ Can I remove 'git-upload-tar' command ? If so, the current
     implementation of 'git-upload-archive' won't work with the old
     'git-tar-tree --remote' command because the protocol needs a
     "argument --format" to be passed to the server. Therefore we can
     either modify 'git-tar-tree' or simply remove it.

  3/ Should I kill 'git-zip-tree' command ? If so should I rename
     builtin-zip-tree.c file into zip-tree.c or something else ?

  4/ Progress indicator support. Junio wants to mimic upload-pack for
     that. But it will lead in a lot of duplicated code if we don't
     try to share code. Can we copy that code anyways and clean up
     later ?

  5/ Should we use "struct tree_desc" based interface for tree parsing
     ? According to Rene it doesn't worth it as soon as you actually
     start to do something to the trees

  6/ Simple subtree matching would be enough, at least for now.

Did I forgot something else ?

Point 1 seems to be important. As soons as we plug git-upload-archive,
we need to control what kind of formats the server deal with.

Point 2 and 3 are easy to achieve, just need a "go wild" authorization.

Point 4, seems to be high in priority since we don't want to deal with
clients and servers interoperate issues.

Points 5 and 6 can be done later. These improvements won't break if
done after releasing.

		Franck

  reply	other threads:[~2006-09-07 13:08 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-05 12:16 [PATCH 1/2] Add git-archive Franck Bui-Huu
2006-09-05 19:23 ` Junio C Hamano
2006-09-06 13:46   ` Franck Bui-Huu
2006-09-06 20:14     ` Rene Scharfe
2006-09-06 20:29       ` Jakub Narebski
2006-09-08 20:21         ` Rene Scharfe
2006-09-06 21:42     ` Junio C Hamano
2006-09-07  6:32       ` Franck Bui-Huu
2006-09-07  7:19         ` Junio C Hamano
2006-09-07  7:53           ` Franck Bui-Huu
2006-09-07  8:16             ` Junio C Hamano
2006-09-07 13:08               ` Franck Bui-Huu [this message]
2006-09-07 13:12                 ` [PATCH 1/4] " Franck Bui-Huu
2006-09-08  2:35                   ` Junio C Hamano
2006-09-08  9:00                     ` Franck Bui-Huu
2006-09-08 20:21                       ` Rene Scharfe
2006-09-09 14:31                         ` Franck Bui-Huu
2006-09-09 15:02                           ` Rene Scharfe
2006-09-09 15:25                             ` Franck Bui-Huu
2006-09-07 13:12                 ` [PATCH 2/4] git-archive: wire up TAR format Franck Bui-Huu
2006-09-08 20:21                   ` Rene Scharfe
2006-09-08 21:42                     ` Junio C Hamano
2006-09-09  1:53                       ` Junio C Hamano
2006-09-09 15:02                         ` Rene Scharfe
2006-09-09 15:10                         ` Franck Bui-Huu
2006-09-09 19:42                           ` Junio C Hamano
2006-09-10 16:10                             ` [PATCH] Use xstrdup instead of strdup in builtin-{tar,zip}-tree.c Rene Scharfe
2006-09-09 14:38                     ` [PATCH 2/4] git-archive: wire up TAR format Franck Bui-Huu
2006-09-07 13:12                 ` [PATCH 3/4] git-archive: wire up ZIP format Franck Bui-Huu
2006-09-07 13:12                 ` [PATCH 4/4] Add git-upload-archive Franck Bui-Huu
2006-09-07 17:26                 ` Add git-archive [take #2] Franck Bui-Huu
2006-09-08  0:37                 ` Junio C Hamano
2006-09-08  8:18                   ` Franck Bui-Huu
2006-09-08  8:47                     ` Jakub Narebski
2006-09-08  8:58                     ` Junio C Hamano
2006-09-08  9:43                       ` Franck Bui-Huu
2006-09-08 21:42                         ` Junio C Hamano
2006-09-08 20:21                   ` Rene Scharfe
2006-09-08 21:42                     ` Junio C Hamano
2006-09-06 20:17 ` [PATCH 1/2] Add git-archive Rene Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450019C3.4030001@innova-card.com \
    --to=vagabon.xyz@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=junkio@cox.net \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).