git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/4] Add git-archive
Date: Sat, 09 Sep 2006 17:02:35 +0200	[thread overview]
Message-ID: <4502D78B.6000905@lsrfire.ath.cx> (raw)
In-Reply-To: <cda58cb80609090731w7c66dcfbrbababb6c38d29bf6@mail.gmail.com>

Franck Bui-Huu schrieb:
> 2006/9/8, Rene Scharfe <rene.scharfe@lsrfire.ath.cx>:
>> > +     url = strdup(ar->remote);
>>
>> xstrdup()
>>
> 
> ok, but need to rebase...

Why?  On a similar note , can we use Junio's pu branch (and soon his
next branch) as our base for further work?

>> > +     if (list) {
>> > +             if (!remote) {
>> > +                     for (i = 0; i < ARRAY_SIZE(archivers); i++)
>> > +                             printf("%s\n", archivers[i].name);
>> > +                     exit(0);
>> > +             }
>> > +             die("--list and --remote are mutually exclusive");
>> > +     }
>>
>> Not sure if we really need a list option.  I guess it only really
>> makes sense if we have more than five formats.  I have no _strong_
>> feelings against it, though. *shrug*
>>
> 
> well it's almost free to add it, and no need any maintenance if we add
> a new archiver backend, so I would say let it.

I thought a bit about it, and I can now see a good use case for --list:
checking the capabilities of a remote site.  Unfortunately this is
currently forbidden.  Why?  git-archive --list writes to stdout, so the
result can be transported the same way an archive would.

René

  reply	other threads:[~2006-09-09 15:02 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-05 12:16 [PATCH 1/2] Add git-archive Franck Bui-Huu
2006-09-05 19:23 ` Junio C Hamano
2006-09-06 13:46   ` Franck Bui-Huu
2006-09-06 20:14     ` Rene Scharfe
2006-09-06 20:29       ` Jakub Narebski
2006-09-08 20:21         ` Rene Scharfe
2006-09-06 21:42     ` Junio C Hamano
2006-09-07  6:32       ` Franck Bui-Huu
2006-09-07  7:19         ` Junio C Hamano
2006-09-07  7:53           ` Franck Bui-Huu
2006-09-07  8:16             ` Junio C Hamano
2006-09-07 13:08               ` Add git-archive [take #2] Franck Bui-Huu
2006-09-07 13:12                 ` [PATCH 1/4] Add git-archive Franck Bui-Huu
2006-09-08  2:35                   ` Junio C Hamano
2006-09-08  9:00                     ` Franck Bui-Huu
2006-09-08 20:21                       ` Rene Scharfe
2006-09-09 14:31                         ` Franck Bui-Huu
2006-09-09 15:02                           ` Rene Scharfe [this message]
2006-09-09 15:25                             ` Franck Bui-Huu
2006-09-07 13:12                 ` [PATCH 2/4] git-archive: wire up TAR format Franck Bui-Huu
2006-09-08 20:21                   ` Rene Scharfe
2006-09-08 21:42                     ` Junio C Hamano
2006-09-09  1:53                       ` Junio C Hamano
2006-09-09 15:02                         ` Rene Scharfe
2006-09-09 15:10                         ` Franck Bui-Huu
2006-09-09 19:42                           ` Junio C Hamano
2006-09-10 16:10                             ` [PATCH] Use xstrdup instead of strdup in builtin-{tar,zip}-tree.c Rene Scharfe
2006-09-09 14:38                     ` [PATCH 2/4] git-archive: wire up TAR format Franck Bui-Huu
2006-09-07 13:12                 ` [PATCH 3/4] git-archive: wire up ZIP format Franck Bui-Huu
2006-09-07 13:12                 ` [PATCH 4/4] Add git-upload-archive Franck Bui-Huu
2006-09-07 17:26                 ` Add git-archive [take #2] Franck Bui-Huu
2006-09-08  0:37                 ` Junio C Hamano
2006-09-08  8:18                   ` Franck Bui-Huu
2006-09-08  8:47                     ` Jakub Narebski
2006-09-08  8:58                     ` Junio C Hamano
2006-09-08  9:43                       ` Franck Bui-Huu
2006-09-08 21:42                         ` Junio C Hamano
2006-09-08 20:21                   ` Rene Scharfe
2006-09-08 21:42                     ` Junio C Hamano
2006-09-06 20:17 ` [PATCH 1/2] Add git-archive Rene Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4502D78B.6000905@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=vagabon.xyz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).