git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Auke Kok <auke-jan.h.kok@intel.com>
To: git@vger.kernel.org
Subject: stgit: cannot push a patch - Python trace dump
Date: Thu, 14 Sep 2006 22:07:48 -0700	[thread overview]
Message-ID: <450A3524.5040403@intel.com> (raw)


Hi all,

I'm preparing patches for upstream and am haunted by an apparent patch breaking
stg. The problem appears to be one or more of my patches breaking a push:

$ stg push
Traceback (most recent call last):
   File "/usr/bin/stg", line 43, in ?
     main()
   File "/usr/lib/python2.4/site-packages/stgit/main.py", line 255, in main
     command.func(parser, options, args)
   File "/usr/lib/python2.4/site-packages/stgit/commands/push.py", line 101, in
func
     push_patches(patches, options.merged)
   File "/usr/lib/python2.4/site-packages/stgit/commands/common.py", line 160,
in push_patches
     forwarded = crt_series.forward_patches(patches)
   File "/usr/lib/python2.4/site-packages/stgit/stack.py", line 789, in
forward_patches
     committer_email = committer_email)
   File "/usr/lib/python2.4/site-packages/stgit/git.py", line 439, in commit
     if message[-1:] != '\n':
TypeError: unsubscriptable object


I've been abusing stg by leaving the commit messages empty so I assume that
that's the cause here, or related to the problem.

This happens with today's stg as well as stg-0.10

After scraping all my patches out manually and adding meaningfull (non-empty) 
commit messages I seem to be able to push and pop them all again.

Cheers,

Auke

             reply	other threads:[~2006-09-15  5:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-15  5:07 Auke Kok [this message]
2006-09-15  8:58 ` stgit: cannot push a patch - Python trace dump Catalin Marinas
2006-09-15 14:26   ` Auke Kok
2006-09-15 14:33     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450A3524.5040403@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).