git-tar-tree & NEEDS_PREFIX

git-tar-tree & NEEDS_PREFIX

[Jiri Slaby]

Hi,

is there any good reason to have NEEDS_PREFIX flag for git-tar-tree builtin?

I can't do --remote= tar-ing, but when I remove this flag from git.c, it seems 
to work correctly (prefix seems not to be used in any way).

regards,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E

Re: git-tar-tree & NEEDS_PREFIX

[Rene Scharfe]

Jiri Slaby schrieb:
> is there any good reason to have NEEDS_PREFIX flag for git-tar-tree
> builtin?
> 
> I can't do --remote= tar-ing, but when I remove this flag from git.c, it
> seems to work correctly (prefix seems not to be used in any way).

Good point.  However, git-tar-tree has been deprecated in favour of
git-archive.  And NEEDS_PREFIX has been renamed to RUN_SETUP two months
ago, so an update might be in order. ;-)

René

[PATCH] git-tar-tree: don't RUN_SETUP

[Rene Scharfe]

Noted by Jiri Slaby, git-tar-tree --remote doesn't need to be run
from inside of a git archive.  Since git-tar-tree is now only a
wrapper for git-archive, which calls setup_git_directory() as
needed, we should drop the flag RUN_SETUP.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---

diff --git a/git.c b/git.c
index b8e8622..d7103a4 100644
--- a/git.c
+++ b/git.c
@@ -258,7 +258,7 @@ static void handle_internal_command(int 
 		{ "show", cmd_show, RUN_SETUP | USE_PAGER },
 		{ "stripspace", cmd_stripspace },
 		{ "symbolic-ref", cmd_symbolic_ref, RUN_SETUP },
-		{ "tar-tree", cmd_tar_tree, RUN_SETUP },
+		{ "tar-tree", cmd_tar_tree },
 		{ "unpack-objects", cmd_unpack_objects, RUN_SETUP },
 		{ "update-index", cmd_update_index, RUN_SETUP },
 		{ "update-ref", cmd_update_ref, RUN_SETUP },