git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: A Large Angry SCM <gitzilla@gmail.com>
To: apodtele <apodtele@gmail.com>
Cc: Martin Waitz <tali@admingilde.org>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] diff --stat: use asymptotic scaling in graph
Date: Thu, 12 Oct 2006 15:20:09 -0700	[thread overview]
Message-ID: <452EBF99.5020108@gmail.com> (raw)
In-Reply-To: <d620685f0610121437m38eb454g7597b2a93010b023@mail.gmail.com>

apodtele wrote:
> On 10/12/06, Martin Waitz <tali@admingilde.org> wrote:
>> On Thu, Oct 12, 2006 at 03:37:17PM -0400, apodtele wrote:
>> > Instead of conditionally scaling the stat graph for large changes,
>> > always scale it asymptotically: small changes shall appear without any
>> > distortions.
>>
>> very nice idea!
>>
>> > +     return it * width / (it + width) + 1;
>>
>> but wouldn't this formula result in at least 1, even for a 0 change?
>> Perhaps we'd have to special case an input of 0?
[...]
> +    if (it)
> +        return it * width / (it + width) + 1;
> +    else
> +        return 0;

No conditional needed:

	return it * width / (it + width - 1)

  reply	other threads:[~2006-10-12 22:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-12 19:37 [PATCH 1/2] diff --stat: use asymptotic scaling in graph apodtele
2006-10-12 20:16 ` Martin Waitz
2006-10-12 21:37   ` apodtele
2006-10-12 22:20     ` A Large Angry SCM [this message]
2006-10-12 22:27       ` Martin Waitz
2006-10-12 22:48         ` A Large Angry SCM
2006-10-12 22:52           ` Johannes Schindelin
2006-10-12 23:12             ` apodtele
2006-10-13  0:39           ` Nicolas Pitre
2006-10-13 13:25             ` apodtele
2006-10-13 13:31               ` Andy Whitcroft
2006-10-12 21:53 ` Junio C Hamano
2006-10-12 22:15   ` A Large Angry SCM
2006-10-12 22:24   ` Junio C Hamano
2006-10-13 13:56   ` apodtele
2006-10-14 19:06     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=452EBF99.5020108@gmail.com \
    --to=gitzilla@gmail.com \
    --cc=apodtele@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=tali@admingilde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).