git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* git.kernel.org disconnects when git-1.3.3 tries to pull changes
@ 2006-10-24  0:03 Simon Arlott
  2006-10-24  1:23 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Arlott @ 2006-10-24  0:03 UTC (permalink / raw)
  To: git

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

$ git --version
git version 1.3.3

$ git pull
fatal: unexpected EOF
Fetch failure: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git/

[pid 14283] write(3, "0046git-upload-pack /pub/scm/linux/kernel/git/torvalds/linux-2.6.git/\n", 70) = 70

$ nc -vv git.kernel.org git
DNS fwd/rev mismatch: zeus-pub.kernel.org != zeus-pub1.kernel.org
DNS fwd/rev mismatch: zeus-pub.kernel.org != zeus-pub2.kernel.org
zeus-pub.kernel.org [204.152.191.5] 9418 (git) open
0046git-upload-pack /pub/scm/linux/kernel/git/torvalds/linux-2.6.git/
 sent 70, rcvd 0
$

<pasky> the difference seems to be just that newer git version sends a host information
<pasky> anyway, this isn't supposed to happen
<pasky> could you mail the mailing list, please?

-- 
Simon Arlott


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 829 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git.kernel.org disconnects when git-1.3.3 tries to pull changes
  2006-10-24  0:03 git.kernel.org disconnects when git-1.3.3 tries to pull changes Simon Arlott
@ 2006-10-24  1:23 ` Junio C Hamano
  2006-10-30 19:53   ` Jon Loeliger
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2006-10-24  1:23 UTC (permalink / raw)
  To: Simon Arlott; +Cc: git

Yes, this is a recent breakage.  Thanks for bringing it up.

We need at least a fix like this in 'maint'.

diff --git a/daemon.c b/daemon.c
index ad84928..e66bb80 100644
--- a/daemon.c
+++ b/daemon.c
@@ -450,6 +450,8 @@ void fill_in_extra_table_entries(struct 
 	 * Replace literal host with lowercase-ized hostname.
 	 */
 	hp = interp_table[INTERP_SLOT_HOST].value;
+	if (!hp)
+		return;
 	for ( ; *hp; hp++)
 		*hp = tolower(*hp);
 
@@ -544,8 +546,10 @@ #endif
 		loginfo("Extended attributes (%d bytes) exist <%.*s>",
 			(int) pktlen - len,
 			(int) pktlen - len, line + len + 1);
-	if (len && line[len-1] == '\n')
+	if (len && line[len-1] == '\n') {
 		line[--len] = 0;
+		pktlen--;
+	}
 
 	/*
 	 * Initialize the path interpolation table for this connection.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: git.kernel.org disconnects when git-1.3.3 tries to pull changes
  2006-10-24  1:23 ` Junio C Hamano
@ 2006-10-30 19:53   ` Jon Loeliger
  0 siblings, 0 replies; 3+ messages in thread
From: Jon Loeliger @ 2006-10-30 19:53 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Simon Arlott, Git List

On Mon, 2006-10-23 at 20:23, Junio C Hamano wrote:
> Yes, this is a recent breakage.  Thanks for bringing it up.
> 
> We need at least a fix like this in 'maint'.

Oooo...  Sorry.  That looks like my bad.

Thanks.

jdl


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-10-30 20:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-24  0:03 git.kernel.org disconnects when git-1.3.3 tries to pull changes Simon Arlott
2006-10-24  1:23 ` Junio C Hamano
2006-10-30 19:53   ` Jon Loeliger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).