* gitweb.cgi and git instaweb
@ 2006-10-26 18:49 Aneesh Kumar K.V
2006-10-27 5:56 ` Aneesh Kumar K.V
0 siblings, 1 reply; 5+ messages in thread
From: Aneesh Kumar K.V @ 2006-10-26 18:49 UTC (permalink / raw)
To: git
I am getting errors as below with git instaweb.
kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb
2006-10-27 00:12:56: (log.c.75) server started
kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.
[Fri Oct 27 00:13:21 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.
[Fri Oct 27 00:13:37 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.
[Fri Oct 27 00:13:58 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.
[Fri Oct 27 00:14:08 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.
[Fri Oct 27 00:14:08 2006] gitweb.cgi: Use of uninitialized value in open at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 1118.
fatal: ambiguous argument '': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions
[Fri Oct 27 00:14:16 2006] gitweb.cgi: "our" variable $stylesheet masks earlier declaration in same scope at /home/opensource/vanilla/linux-2.6-git/.git/gitweb/gitweb.cgi line 59.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: gitweb.cgi and git instaweb
2006-10-26 18:49 gitweb.cgi and git instaweb Aneesh Kumar K.V
@ 2006-10-27 5:56 ` Aneesh Kumar K.V
2006-10-27 7:05 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Aneesh Kumar K.V @ 2006-10-27 5:56 UTC (permalink / raw)
To: Aneesh Kumar K.V, git
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
Aneesh Kumar K.V wrote:
> I am getting errors as below with git instaweb.
>
>
> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb
> 2006-10-27 00:12:56: (log.c.75) server started
> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27
> 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier
> declaration in same scope at
>
The attached patch should fix it.
-aneesh
[-- Attachment #2: gitweb.perl.diff --]
[-- Type: text/x-patch, Size: 445 bytes --]
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ba7a42a..1962c76 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -55,8 +55,6 @@ our $stylesheet;
# default is not to define style sheet, but it can be overwritten later
undef $stylesheet;
-# URI of default stylesheet
-our $stylesheet = "++GITWEB_CSS++";
# URI of GIT logo (72x27 size)
our $logo = "++GITWEB_LOGO++";
# URI of GIT favicon, assumed to be image/png type
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: gitweb.cgi and git instaweb
2006-10-27 5:56 ` Aneesh Kumar K.V
@ 2006-10-27 7:05 ` Junio C Hamano
2006-10-27 8:58 ` Aneesh Kumar K.V
2006-10-27 10:32 ` Petr Baudis
0 siblings, 2 replies; 5+ messages in thread
From: Junio C Hamano @ 2006-10-27 7:05 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: git
"Aneesh Kumar K.V" <aneesh.kumar@gmail.com> writes:
> Aneesh Kumar K.V wrote:
>> I am getting errors as below with git instaweb.
>>
>>
>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb
>> 2006-10-27 00:12:56: (log.c.75) server started
>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27
>> 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier
>> declaration in same scope at
>>
>
> The attached patch should fix it.
>
> -aneesh
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index ba7a42a..1962c76 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -55,8 +55,6 @@ our $stylesheet;
> # default is not to define style sheet, but it can be overwritten later
> undef $stylesheet;
>
> -# URI of default stylesheet
> -our $stylesheet = "++GITWEB_CSS++";
> # URI of GIT logo (72x27 size)
> our $logo = "++GITWEB_LOGO++";
> # URI of GIT favicon, assumed to be image/png type
Removing the extraneous undef would also be a good idea,
wouldn't it?
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index aceaeb7..7999b1a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -51,12 +51,10 @@ our $site_footer = "++GITWEB_SITE_FOOTER
# URI of stylesheets
our @stylesheets = ("++GITWEB_CSS++");
-our $stylesheet;
-# default is not to define style sheet, but it can be overwritten later
-undef $stylesheet;
-
# URI of default stylesheet
-our $stylesheet = "++GITWEB_CSS++";
+# default is not to define style sheet, but it can be overwritten later.
+our $stylesheet = undef;
+
# URI of GIT logo (72x27 size)
our $logo = "++GITWEB_LOGO++";
# URI of GIT favicon, assumed to be image/png type
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: gitweb.cgi and git instaweb
2006-10-27 7:05 ` Junio C Hamano
@ 2006-10-27 8:58 ` Aneesh Kumar K.V
2006-10-27 10:32 ` Petr Baudis
1 sibling, 0 replies; 5+ messages in thread
From: Aneesh Kumar K.V @ 2006-10-27 8:58 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Junio C Hamano wrote:
> "Aneesh Kumar K.V" <aneesh.kumar@gmail.com> writes:
>
>> Aneesh Kumar K.V wrote:
>>> I am getting errors as below with git instaweb.
>>>
>>>
>>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ git instaweb
>>> 2006-10-27 00:12:56: (log.c.75) server started
>>> kvaneesh@satan:/home/opensource/vanilla/linux-2.6-git$ [Fri Oct 27
>>> 00:12:57 2006] gitweb.cgi: "our" variable $stylesheet masks earlier
>>> declaration in same scope at
>>>
>> The attached patch should fix it.
>>
>> -aneesh
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index ba7a42a..1962c76 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -55,8 +55,6 @@ our $stylesheet;
>> # default is not to define style sheet, but it can be overwritten later
>> undef $stylesheet;
>>
>> -# URI of default stylesheet
>> -our $stylesheet = "++GITWEB_CSS++";
>> # URI of GIT logo (72x27 size)
>> our $logo = "++GITWEB_LOGO++";
>> # URI of GIT favicon, assumed to be image/png type
>
> Removing the extraneous undef would also be a good idea,
> wouldn't it?
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index aceaeb7..7999b1a 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -51,12 +51,10 @@ our $site_footer = "++GITWEB_SITE_FOOTER
>
> # URI of stylesheets
> our @stylesheets = ("++GITWEB_CSS++");
> -our $stylesheet;
> -# default is not to define style sheet, but it can be overwritten later
> -undef $stylesheet;
> -
> # URI of default stylesheet
> -our $stylesheet = "++GITWEB_CSS++";
> +# default is not to define style sheet, but it can be overwritten later.
> +our $stylesheet = undef;
> +
> # URI of GIT logo (72x27 size)
> our $logo = "++GITWEB_LOGO++";
> # URI of GIT favicon, assumed to be image/png type
>
ACK
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: gitweb.cgi and git instaweb
2006-10-27 7:05 ` Junio C Hamano
2006-10-27 8:58 ` Aneesh Kumar K.V
@ 2006-10-27 10:32 ` Petr Baudis
1 sibling, 0 replies; 5+ messages in thread
From: Petr Baudis @ 2006-10-27 10:32 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Aneesh Kumar K.V, git
Dear diary, on Fri, Oct 27, 2006 at 09:05:20AM CEST, I got a letter
where Junio C Hamano <junkio@cox.net> said that...
> Removing the extraneous undef would also be a good idea,
> wouldn't it?
25746 F Oct 26 Petr Baudis ( 0.9K) [PATCH] gitweb: Fix up bogus $stylesheet declarations
?
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-10-27 10:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-26 18:49 gitweb.cgi and git instaweb Aneesh Kumar K.V
2006-10-27 5:56 ` Aneesh Kumar K.V
2006-10-27 7:05 ` Junio C Hamano
2006-10-27 8:58 ` Aneesh Kumar K.V
2006-10-27 10:32 ` Petr Baudis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).