git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: sf <sf@b-i-t.de>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Martin Langhoff <martin.langhoff@gmail.com>
Subject: Re: Non-ASCII paths and git-cvsserver
Date: Mon, 13 Nov 2006 14:58:33 +0100	[thread overview]
Message-ID: <45587A09.3020605@b-i-t.de> (raw)
In-Reply-To: <7vvelnjd4p.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> sf <sf@b-i-t.de> writes:
> 
>> I want to access a git repository via git-cvsserver. The problem is
>> that the repository contains paths with umlauts. These paths come out
>> quoted and escaped when checked out with cvs.
> 
> I think this is because the cvsserver invokes diff-tree and
> ls-tree without -z and the output from these command quote
> non-ascii letters as unsafe.

I knew I had seen that kind of quoting before but right then I thought 
it was related to Perl or SQLite.

> Martin's sqlite may probably be needed as well, but regardless
> of that something like this patch is needed -- otherwise what 
> populates sqlite database will be quoted to begin with so it
> would not help much.

Martin, are you sure your patch is needed? (see below)

> I've tested with your reproduction recipe, but otherwise not
> tested this patch.

Thanks, Junio. Paths with umlauts are returned correctly now both in 
UTF-8 and ISO-8859-1. I guess git-cvsserver is now as encoding agnostic 
as git core.

Regards


  reply	other threads:[~2006-11-13 13:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-09 11:11 Non-ASCII paths and git-cvsserver sf
2006-11-10 18:59 ` Martin Langhoff
2006-11-10 19:49 ` Junio C Hamano
2006-11-13 13:58   ` sf [this message]
2006-11-13 14:20     ` Jakub Narebski
2006-11-13 18:30       ` Robin Rosenberg
2006-11-13 18:57         ` Jakub Narebski
2006-11-13 21:41           ` Robin Rosenberg
2006-11-13 19:48         ` Junio C Hamano
2006-11-13 18:22     ` Martin Langhoff
2006-11-14 10:40       ` sf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45587A09.3020605@b-i-t.de \
    --to=sf@b-i-t.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=martin.langhoff@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).