git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kir Kolyshkin <kir@openvz.org>
To: git@vger.kernel.org
Subject: [PATCH] gitweb: make HTML links out of http/https URLs in changelogs
Date: Tue, 21 Nov 2006 23:02:36 +0100	[thread overview]
Message-ID: <4563777C.4050108@openvz.org> (raw)

It is a common practice to put links to bugzillas, mailing lists, etc. 
in git log entries. The fact that gitweb doesn't make HTML links out of 
that URLs makes following those URLs inconvenient. This patch fixes that 
problem, trying to address cases when URL is enclosed in round or square 
brackets.

Slightly tested on http://git.openvz.org/. Applicable to git-1.4.4.

Signed-off-by: Kir Kolyshkin <kir@openvz.org>
---
 gitweb/gitweb.perl |    2 ++
 1 file changed, 2 insertions(+)

--- git-1.4.4/gitweb/gitweb.perl	2006-11-15 08:22:27.000000000 +0100
+++ git-1.4.4-my/gitweb/gitweb.perl	2006-11-21 22:49:14.000000000 +0100
@@ -828,6 +828,8 @@
 			$line =~ s/$hash_text/$link/;
 		}
 	}
+	# make HTML links out of http(s) URLs
+	$line =~ s/(http[s]?:\/\/[^[:space:]\]\)]+)/<a href="\1">\1<\/a>/g;
 	return $line;
 }
 


             reply	other threads:[~2006-11-21 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-21 22:02 Kir Kolyshkin [this message]
2006-11-21 22:28 ` [PATCH] gitweb: make HTML links out of http/https URLs in changelogs Jakub Narebski
2006-11-21 23:55 ` Randal L. Schwartz
2006-11-22  0:06 ` Petr Baudis
2006-11-22  9:00   ` Kir Kolyshkin
2006-11-22 20:56     ` Petr Baudis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4563777C.4050108@openvz.org \
    --to=kir@openvz.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).