From: Andreas Ericsson <ae@op5.se>
To: hanwen@xs4all.nl
Cc: Jakub Narebski <jnareb@gmail.com>, git@vger.kernel.org
Subject: Re: bug: git-sh-setup should not be in $PATH
Date: Thu, 07 Dec 2006 14:36:37 +0100 [thread overview]
Message-ID: <457818E5.5010008@op5.se> (raw)
In-Reply-To: <4576E9DF.5090709@xs4all.nl>
Han-Wen Nienhuys wrote:
> Since git does recursive makes, among others in
>
> perl/
> Documentation/
> templates/
> contrib/
>
> there should be Makefiles in said directories. Otherwise, every rule
> in the toplevel Makefile saying
>
>
> $(MAKE) -C subdir/
>
> will fail because $builddir/ does not have a Makefile in
> $builddir/subdir.
>
This part should have been in the commit message, possibly without the
"among others ... (examples)" and possibly with an added "This patch
makes it so by letting fnurg create them through smurfing the frotz".
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
prev parent reply other threads:[~2006-12-07 13:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-06 12:14 bug: git-sh-setup should not be in $PATH Han-Wen Nienhuys
2006-12-06 12:23 ` Johannes Schindelin
2006-12-06 12:34 ` Han-Wen Nienhuys
2006-12-06 12:56 ` Jakub Narebski
2006-12-06 14:16 ` Han-Wen Nienhuys
2006-12-06 14:51 ` Jakub Narebski
2006-12-06 15:03 ` Han-Wen Nienhuys
2006-12-06 15:27 ` Jakub Narebski
2006-12-06 15:36 ` Han-Wen Nienhuys
2006-12-06 15:56 ` Jakub Narebski
2006-12-06 16:03 ` Han-Wen Nienhuys
2006-12-06 16:27 ` Jakub Narebski
2006-12-06 16:40 ` Han-Wen Nienhuys
2006-12-06 16:52 ` Jakub Narebski
2006-12-06 16:56 ` Han-Wen Nienhuys
2006-12-06 17:11 ` Jakub Narebski
2006-12-07 13:36 ` Andreas Ericsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457818E5.5010008@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=hanwen@xs4all.nl \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).