From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.176.0/21 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 From: Andreas Ericsson Subject: Re: [PATCH] make commit message a little more consistent and conforting Date: Fri, 15 Dec 2006 16:32:50 +0100 Message-ID: <4582C022.3030706@op5.se> References: <7v4przfpir.fsf@assigned-by-dhcp.cox.net> <200612132237.10051.andyparkins@gmail.com> <7vk60vbcfz.fsf@assigned-by-dhcp.cox.net> <200612140959.19209.andyparkins@gmail.com> <7v7iwu93rv.fsf@assigned-by-dhcp.cox.net> <20061215042459.GC27343@spearce.org> <45825E0B.5010200@op5.se> <20061215150909.GE17860@spearce.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit NNTP-Posting-Date: Fri, 15 Dec 2006 15:33:05 +0000 (UTC) Cc: Nicolas Pitre , Junio C Hamano , Andy Parkins , git@vger.kernel.org Return-path: Envelope-to: gcvg-git@gmane.org User-Agent: Thunderbird 1.5.0.7 (X11/20060913) In-Reply-To: <20061215150909.GE17860@spearce.org> Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Received: from vger.kernel.org ([209.132.176.167]) by dough.gmane.org with esmtp (Exim 4.50) id 1GvF3P-0002H5-H8 for gcvg-git@gmane.org; Fri, 15 Dec 2006 16:32:55 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752695AbWLOPcx (ORCPT ); Fri, 15 Dec 2006 10:32:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752731AbWLOPcx (ORCPT ); Fri, 15 Dec 2006 10:32:53 -0500 Received: from linux-server1.op5.se ([193.201.96.2]:54877 "EHLO smtp-gw1.op5.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbWLOPcw (ORCPT ); Fri, 15 Dec 2006 10:32:52 -0500 Received: from [192.168.1.20] (unknown [213.88.215.14]) by smtp-gw1.op5.se (Postfix) with ESMTP id 4028E6BCC7; Fri, 15 Dec 2006 16:32:51 +0100 (CET) To: Shawn Pearce Sender: git-owner@vger.kernel.org Shawn Pearce wrote: > Andreas Ericsson wrote: >> Shawn Pearce wrote: >>> Nicolas Pitre wrote: >>>> It is nicer to let the user know when a commit succeeded all the time, >>>> not only the first time. Also the commit sha1 is much more useful than >>>> the tree sha1 in this case. >>> I agree the commit sha1 is more useful than the tree sha1, but I'm >>> not really sure its useful to show the commit sha1 post commit. >>> If you want to show something the diffstat like what git merge does >>> is better. >>> >> diffstats can be huge though. I'd rather have those only with -v option. > > But they are on by default for pull/merge, and disabled by -n. > Yes, but it makes sense for merges where you generally pull someone elses work or one of your topic branches because it gives a general feel for the amount of modifications and are a sort of conclusion. Commits are a different thing, because you should know what kind of changes you've just done. If you don't you have other problems. I for one run git diff quite frequently when I'm getting close to a commit to make sure I don't get only the changes I want. I imagine others do too, so getting a diffstat when issuing the actual commit would just be noisy and irritating. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se