From: Quy Tonthat <qtonthat@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-branch: deleting remote branches in new layout
Date: Mon, 18 Dec 2006 21:02:05 +1100 [thread overview]
Message-ID: <4586671D.5020305@gmail.com> (raw)
In-Reply-To: <7vodq11w49.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> How about this instead?
>
> Because -r already means "remote" when listing, you can say:
>
> $ git branch -d -r origin/todo origin/html origin/man
>
> I just twisted it not to do fast-forward check with the current
> branch, because remote tracking branches are more like tags than
> branches, and when you are removing them, most likely that is
> not because you are "done with" them (for a local branch, it
> usually means "you merged it up") but because you are not even
> interested in them.
It sure is much more unambiguous that way.
Users won't be able to mix "local" and "remote" on one command
line as they were with the old layout. But that's OK for such an
infrequently used command.
> if (!resolve_ref(name, sha1, 1, NULL))
> - die("Branch '%s' not found.", argv[i]);
> + die("%sbranch '%s' not found.", remote, argv[i]);
This should not be a fatal error. We should only give warning
and move on to the next item. The way "rm" does.
Quy
next prev parent reply other threads:[~2006-12-18 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 6:08 [PATCH] git-branch: deleting remote branches in new layout Quy Tonthat
2006-12-18 7:08 ` Junio C Hamano
2006-12-18 7:49 ` Junio C Hamano
2006-12-18 10:02 ` Quy Tonthat [this message]
2006-12-18 13:39 ` [PATCH] (Take 2) " Quy Tonthat
2006-12-18 22:42 ` [PATCH] (Take 3) " Quy Tonthat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4586671D.5020305@gmail.com \
--to=qtonthat@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox