From: Timur Tabi <timur@freescale.com>
To: git@vger.kernel.org
Subject: git-send-email --suppress-from option doesn't work.
Date: Thu, 18 Jan 2007 15:07:24 -0600 [thread overview]
Message-ID: <45AFE18C.2020303@freescale.com> (raw)
The --suppress-from option doesn't work for me because the comparison is too strict.
Here's an example usage of git-send-email:
git-send-email --suppress-from --from timur@freescale.com --to timur@tabi.org
--smtp-server remotesmtp.freescale.net 0001-Add-support-for-the-MPC8349E-mITX-GP.txt
I need to specify the --from option, because otherwise git-send-email will
prompt me for a From address, and I don't want it to prompt me for anything.
The problem is that the patchfile contains this line:
From: Timur Tabi <timur@freescale.com>
That means that the patchfile contains the string "Timur Tabi
<timur@freescale.com>", but the --from specifies the string
"timur@freescale.com". The code which checks the suppress-from option is here:
} elsif (/^(Cc|From):\s+(.*)$/) {
if ($2 eq $from) {
next if ($suppress_from);
}
I don't know Perl, but I'm guess the The "$2 eq $from" is a strict comparison
that fails in my case.
Some of you might say at this point, "Why don't you just specify --from "Timur
Tabi <timur@freescale.com>"? I tried that, and it still doesn't work.
Basically, what I want is to prevent git-send-email from CC'ing me on my own
patches. No matter what I do, I can't prevent it from adding "Cc: Timur Tabi
<timur@freescale.com>" to the email header.
--
Timur Tabi
Linux Kernel Developer @ Freescale
next reply other threads:[~2007-01-18 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 21:07 Timur Tabi [this message]
2007-01-19 1:24 ` git-send-email --suppress-from option doesn't work Andreas Ericsson
2007-01-25 16:47 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AFE18C.2020303@freescale.com \
--to=timur@freescale.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).