git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Han-Wen Nienhuys <hanwen@xs4all.nl>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>,
	Andy Parkins <andyparkins@gmail.com>,
	junkio@cox.net, git@vger.kernel.org
Subject: Re: [PATCH] config: read system-wide defaults from /etc/gitconfig
Date: Wed, 14 Feb 2007 19:10:26 +0100	[thread overview]
Message-ID: <45D35092.8040901@xs4all.nl> (raw)
In-Reply-To: <Pine.LNX.4.63.0702141246160.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin escreveu:
> The settings in /etc/gitconfig can be overridden in ~/.gitconfig,
> which in turn can be overridden in .git/config.

> +#define ETC_GITCONFIG "/etc/gitconfig"

> +		if (!access(ETC_GITCONFIG, R_OK))
> +			ret += git_config_from_file(fn, ETC_GITCONFIG);

this is a stupid idea.  

This should use the path given as the --sysconfdir argument to configure. 
If the configure result is not available, it should default to $prefix/etc/ 

It should be possible to install private copy of Git without being affected
by system wide defaults.


-- 
 Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

  parent reply	other threads:[~2007-02-14 18:11 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14  9:09 /etc/gitconfig Andy Parkins
2007-02-14 10:30 ` /etc/gitconfig Peter Baumann
2007-02-14 11:48   ` [PATCH] config: read system-wide defaults from /etc/gitconfig Johannes Schindelin
2007-02-14 16:30     ` Junio C Hamano
2007-02-14 17:45       ` Johannes Schindelin
2007-02-14 17:57         ` Junio C Hamano
2007-02-14 18:02           ` Johannes Schindelin
2007-02-14 18:12             ` Junio C Hamano
2007-02-14 18:19               ` Nicolas Pitre
2007-02-14 19:06                 ` Junio C Hamano
2007-02-15 10:19       ` Andy Parkins
2007-02-15 11:26         ` Junio C Hamano
     [not found]         ` <20070215113557.GB2282@steel.home>
     [not found]           ` <20070216143952.GA2478@steel.home>
2007-02-16 14:42             ` [PATCH] Allow config files to be included Alex Riesen
2007-02-16 14:45               ` Alex Riesen
2007-02-14 18:10     ` Han-Wen Nienhuys [this message]
2007-02-14 19:07       ` [PATCH] config: read system-wide defaults from /etc/gitconfig Junio C Hamano
2007-02-14 19:25         ` Johannes Schindelin
2007-02-14 19:43           ` Junio C Hamano
2007-02-14 19:54             ` Johannes Schindelin
2007-02-14 22:39               ` Johannes Schindelin
2007-02-15  5:27               ` Junio C Hamano
2007-02-15  8:46                 ` Junio C Hamano
2007-02-15  9:59                   ` Eric Wong
2007-02-15 10:03                     ` Eric Wong
2007-02-15 10:36                     ` Junio C Hamano
2007-02-15 10:43                 ` Johannes Schindelin
2007-02-15 11:25                   ` Junio C Hamano
2007-02-15 12:05                     ` Johannes Schindelin
2007-02-19  1:47                     ` Jakub Narebski
2007-02-14 10:40 ` /etc/gitconfig Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D35092.8040901@xs4all.nl \
    --to=hanwen@xs4all.nl \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=siprbaum@stud.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).