git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: "Karl Hasselström" <kha@treskal.com>
Cc: Junio C Hamano <junkio@cox.net>, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 5/6] Fix some "comparison is always true/false" warnings.
Date: Wed, 07 Mar 2007 19:05:49 +0000	[thread overview]
Message-ID: <45EF0D0D.4060904@ramsay1.demon.co.uk> (raw)
In-Reply-To: <20070305074502.GA31507@diana.vm.bytemark.co.uk>

Karl Hasselström wrote:
> On 2007-03-03 18:28:57 +0000, Ramsay Jones wrote:
> 
>> +typedef unsigned int ucs_char_t;  /* assuming 32bit int */
> 
> Umm ... wouldn't an uint32_t be a better fit here?
> 

Yes, but I did not want to add a dependency on a C99 header
(i.e. <stdint.h>). I had a vague recollection that Linus had
stated that git was probably broken if int wasn't 32 bits, so ...

This was before I realized that a recent change to git meant
that git was already including C99 headers <inttypes.h> and,
therefore indirectly, <stdint.h>.

So, if it is OK to depend on those headers, then an uin32_t may
indeed be a better fit.

All the best,

Ramsay Jones

  reply	other threads:[~2007-03-07 20:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-03 18:28 [PATCH 5/6] Fix some "comparison is always true/false" warnings Ramsay Jones
2007-03-05  7:45 ` Karl Hasselström
2007-03-07 19:05   ` Ramsay Jones [this message]
2007-03-08  6:45     ` Karl Hasselström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45EF0D0D.4060904@ramsay1.demon.co.uk \
    --to=ramsay@ramsay1.demon.co.uk \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=kha@treskal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).