git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git-upload-pack: the timeout gets corrupted?!
Date: Sun, 11 Mar 2007 01:23:59 -0800	[thread overview]
Message-ID: <45F3CAAF.7030909@zytor.com> (raw)
In-Reply-To: <7vy7m4wcfb.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> 
>> The process spends effectively forever waiting in on the fflush() in
>> show_commit() (in upload-pack.c); /proc/*/fd shows it is trying to
>> write to a pipe, but I'm not sure what is at the other end of that
>> same pipe.
> 
> The process forks and the one that runs show_commit() is running
> rev-list internally while the other end is a pack-objects that
> reads from it and sends its output back to the client.
> 

Now, given that the fact that the git-pack-object process has already 
died, normally one would expect the write() to get SIGPIPE which would 
kill the process.  Does git-upload-pack not close the read end of the 
pipe in the writer?  From the looks of the fd directory, I would say it 
does not.

	-hpa

  parent reply	other threads:[~2007-03-11  9:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-11  1:45 git-upload-pack: the timeout gets corrupted?! H. Peter Anvin
2007-03-11  5:56 ` Junio C Hamano
2007-03-11  9:13   ` H. Peter Anvin
2007-03-11  9:23   ` H. Peter Anvin [this message]
2007-03-11 12:14     ` Johannes Schindelin
2007-03-11 16:01       ` H. Peter Anvin
2007-03-11 22:01         ` Johannes Schindelin
2007-03-11 17:18   ` H. Peter Anvin
2007-03-11 17:23 ` H. Peter Anvin
2007-03-11 17:37   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F3CAAF.7030909@zytor.com \
    --to=hpa@zytor.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).