From: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <junkio@cox.net>, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 1/6] Fix some "printf format" warnings.
Date: Mon, 12 Mar 2007 15:03:49 +0100 [thread overview]
Message-ID: <45F55DC5.8060702@fs.ei.tum.de> (raw)
In-Reply-To: <45EAFD21.6010002@ramsay1.demon.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
Ramsay Jones wrote:
>>> - printf("%s%06o %s %d\t",
>>> + printf("%s%06lo %s %d\t",
>>> tag,
>>> ntohl(ce->ce_mode),
>> I think we should do this instead:
>>
>> printf("%s%06o %s %d\t", tag, (unsigned) ntohl(ce->ce_mode), ...
> Oops, yes you are right.
> (cygwin typedef's uint32_t as unsigned long.)
>
> However, I would hate to add all those casts! Casts are not always
> evil, but should be avoided if possible. Having said that, I don't
> see another solution ...
shouldn't it be something like this?
printf("%s%06"PRIo32" %s %d\t", tag, ntohl(ce->ce_mode), ...)
that's the correct and allegedly portable way I guess.
cheers
simon
--
Serve - BSD +++ RENT this banner advert +++ ASCII Ribbon /"\
Work - Mac +++ space for low €€€ NOW!1 +++ Campaign \ /
Party Enjoy Relax | http://dragonflybsd.org Against HTML \
Dude 2c 2 the max ! http://golden-apple.biz Mail + News / \
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
next prev parent reply other threads:[~2007-03-12 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 18:28 [PATCH 1/6] Fix some "printf format" warnings Ramsay Jones
2007-03-03 21:53 ` Junio C Hamano
2007-03-04 17:08 ` Ramsay Jones
2007-03-12 14:03 ` Simon 'corecode' Schubert [this message]
2007-03-12 19:40 ` Junio C Hamano
2007-03-14 22:57 ` Ramsay Jones
2007-03-14 23:41 ` Junio C Hamano
2007-03-13 22:33 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F55DC5.8060702@fs.ei.tum.de \
--to=corecode@fs.ei.tum.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).