From: Liu Yubao <yubao.liu@gmail.com>
To: Jan Hudec <bulb@ucw.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] remove unnecessary loop
Date: Wed, 09 May 2007 09:03:38 +0800 [thread overview]
Message-ID: <46411DEA.6060404@gmail.com> (raw)
In-Reply-To: <20070508093902.GB9007@efreet.light.src>
Jan Hudec wrote:
> On Tue, May 08, 2007 at 12:49:35 +0800, Liu Yubao wrote:
>> +#ifdef __CYGWIN__
>> + /*
>> + * On cygwin, lstat("hello", &st) returns 0 when
>> + * "hello.exe" exists, so test with open() again.
>> + */
>> + if (lstat(match, &st) && -1 != (fd = open(match, O_RDONLY))) {
>> + struct dir_entry *ent;
>> + close(fd);
>> +#else
>> if (!lstat(match, &st)) {
>> struct dir_entry *ent;
>> -
>> +#endif
>
> You seem to have reversed the sense of the test.
>
Sorry I made a mistake, Junio's suggestion is pretty clean, and
that test should be
if (!lstat(match, &st) && -1 != (fd = open(match, O_RDONLY))) {
Yesterday I digged the Cygwin mail archive, I found it's a concession for windows
as you said in the previous message. I agree with you, just let it be.
Once more, I get the lesson: Windows is poor, sigh...
prev parent reply other threads:[~2007-05-09 1:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 3:18 [PATCH] remove unnecessary loop Liu Yubao
2007-05-08 4:49 ` Liu Yubao
2007-05-08 5:05 ` Junio C Hamano
2007-05-08 9:08 ` Alex Riesen
2007-05-08 10:13 ` Jan Hudec
2007-05-08 12:38 ` Alex Riesen
2007-05-08 12:17 ` Eric Blake
2007-05-08 9:39 ` Jan Hudec
2007-05-09 1:03 ` Liu Yubao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46411DEA.6060404@gmail.com \
--to=yubao.liu@gmail.com \
--cc=bulb@ucw.cz \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).