* [PATCH] missing return
@ 2007-05-30 12:39 Jerald Fitzjerald
2007-05-30 17:24 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jerald Fitzjerald @ 2007-05-30 12:39 UTC (permalink / raw)
To: git; +Cc: jfj
OK for mainline?
---
diff --git a/base85.c b/base85.c
--- a/base85.c
+++ b/base85.c
@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf
*/
if (0x03030303 < acc ||
0xffffffff - de < (acc *= 85))
- error("invalid base85 sequence %.5s", buffer-5);
+ return error("invalid base85 sequence %.5s", buffer-5);
acc += de;
say1(" %08x", acc);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] missing return 2007-05-30 12:39 [PATCH] missing return Jerald Fitzjerald @ 2007-05-30 17:24 ` Junio C Hamano 2007-05-30 19:16 ` Jerald Fitzjerald 0 siblings, 1 reply; 3+ messages in thread From: Junio C Hamano @ 2007-05-30 17:24 UTC (permalink / raw) To: Jerald Fitzjerald; +Cc: git Jerald Fitzjerald <jfj@freemail.gr> writes: > OK for mainline? Sure, with a signoff please. I realize that I've seen this pointed out by somebody already. Thanks for reminder. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] missing return 2007-05-30 17:24 ` Junio C Hamano @ 2007-05-30 19:16 ` Jerald Fitzjerald 0 siblings, 0 replies; 3+ messages in thread From: Jerald Fitzjerald @ 2007-05-30 19:16 UTC (permalink / raw) To: Junio C Hamano; +Cc: git Junio C Hamano wrote: >I realize that I've seen this pointed out by somebody already. > It was suggested on irc a couple of days ago. Signed-off-by: Jerald Fitzjerald <jfj@freemail.gr> --- diff --git a/base85.c b/base85.c --- a/base85.c +++ b/base85.c @@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf */ if (0x03030303 < acc || 0xffffffff - de < (acc *= 85)) - error("invalid base85 sequence %.5s", buffer-5); + return error("invalid base85 sequence %.5s", buffer-5); acc += de; say1(" %08x", acc); ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-30 19:14 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-05-30 12:39 [PATCH] missing return Jerald Fitzjerald 2007-05-30 17:24 ` Junio C Hamano 2007-05-30 19:16 ` Jerald Fitzjerald
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).