From: Johannes Sixt <J.Sixt@eudaptics.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Add basic test-script for git-submodule
Date: Fri, 01 Jun 2007 09:56:12 +0200 [thread overview]
Message-ID: <465FD11C.6B1D5172@eudaptics.com> (raw)
In-Reply-To: op.ts8d71b89pspc6@localhost
Lars Hjemli wrote:
> +test_expect_success 'status should only print one line' '
> + lines=$(git-submodule status | wc -l)
&& is missing.
> + test "$lines" = "1"
Please don't put output of wc in quotes because some versions of wc emit
padding:
test $lines = 1
(without the quotes around 1 - like in other test scripts).
-- Hannes
next prev parent reply other threads:[~2007-06-01 7:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 20:34 [PATCH] Add basic test-script for git-submodule Lars Hjemli
2007-05-29 7:10 ` Junio C Hamano
2007-05-30 6:48 ` Lars Hjemli
2007-06-01 3:54 ` Junio C Hamano
2007-06-01 7:10 ` Lars Hjemli
2007-06-01 7:56 ` Johannes Sixt [this message]
2007-06-01 8:13 ` Lars Hjemli
2007-06-01 19:50 ` Junio C Hamano
2007-06-02 1:27 ` Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465FD11C.6B1D5172@eudaptics.com \
--to=j.sixt@eudaptics.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).