From: Johannes Sixt <J.Sixt@eudaptics.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Accept dates before 2000/01/01 when specified as seconds since the epoch
Date: Wed, 06 Jun 2007 12:42:53 +0200 [thread overview]
Message-ID: <46668FAD.73D1B73F@eudaptics.com> (raw)
In-Reply-To: 7vtztl5vvb.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
>
> I vaguely recall hitting the same issue soon after date.c was
> done, and sending in a patch in the same spirit but with
> different implementation (I essentially duplicated that "seconds
> since epoch" without any cutoff as the last ditch fallback) long
> time ago (this was before I took git over; the patch was rejected).
>
> It almost makes me wonder if it is better to introduce a special
> syntax to denote "seconds since epoch plus timezone offset" for
> our Porcelain use, instead of keeping this arbitrary cut-off
> date which nobody can agree on and which forces us to roll back
> from time to time. For one thing, such a syntax would allow us
> to talk about a timestamp before the epoch.
>
> Perhaps
>
> "epoch" [-+] [0-9]+ " " [-+][0-9][0-9][0-9][0-9]
>
> ?
OTOH, the previous limit 2000/01/01 was completely arbitrary, while the
new limit 100000000secs has some justification: Numbers with fewer
digits could be mistaken as dates.
-- Hannes
next prev parent reply other threads:[~2007-06-06 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 8:11 [PATCH] Accept dates before 2000/01/01 when specified as seconds since the epoch Johannes Sixt
2007-06-06 8:29 ` Junio C Hamano
2007-06-06 10:42 ` Johannes Sixt [this message]
2007-06-07 5:09 ` Sam Vilain
2007-06-07 5:29 ` Junio C Hamano
2007-06-07 5:30 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46668FAD.73D1B73F@eudaptics.com \
--to=j.sixt@eudaptics.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).