Mail after commit

Mail after commit

[Claudio Scordino]

Hi all.

To have an email sent after every commit, I've put the following command in 
.git/hooks/post-commit:

rm -f /tmp/git-commit.patch ; git-format-patch --stdout -s `git log 
--pretty=oneline | awk '{print $1}' | sed -n '2p'` > /tmp/git-commit.patch ; 
git-send-email --no-signed-off-by-cc  --to XXX --from YYY /tmp/git-commit.patch 
; rm -f /tmp/git-commit.patch

and it works, indeed.

However, it's quite tricky.

Doesn't exist any way to make it simpler ?

Regards,

          Claudio

Re: Mail after commit

[Martin Langhoff]

On 6/13/07, Claudio Scordino <cloud.of.andor@gmail.com> wrote:
> Doesn't exist any way to make it simpler ?

I think most people setup gitweb, and follow its rss feed. Not exacty
the same, I know, but quite useful.

cheers,


martin

Re: Mail after commit

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

On Wed, 2007-06-13 08:35:57 +1200, Martin Langhoff <martin.langhoff@gmail.com> wrote:
> On 6/13/07, Claudio Scordino <cloud.of.andor@gmail.com> wrote:
> > Doesn't exist any way to make it simpler ?
> 
> I think most people setup gitweb, and follow its rss feed. Not exacty
> the same, I know, but quite useful.

Erm, no, not really.  Emailing the patches is *quite* useful when
there's a dedicated review team.

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:               The real problem with C++ for kernel modules is:
the second  :                                 the language just sucks.
                                                   -- Linus Torvalds

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Mail after commit

[Andy Parkins]

On Wednesday 2007 June 13, Jan-Benedict Glaw wrote:

> > I think most people setup gitweb, and follow its rss feed. Not exacty
> > the same, I know, but quite useful.
>
> Erm, no, not really.  Emailing the patches is *quite* useful when
> there's a dedicated review team.

As an aside - I find it better to send announce emails on git-push rather than 
git-commit.  If you send an email on git-commit, then your working repository 
becomes a whole lot less useful.

For example I often do:

 git commit -a -m "Shelve what I'm doing right now"
 git checkout -b temporary-branch HEAD^^^
 vim fix-bug-that-I-never-want-anyone-to-see
 git checkout master
 git rebase temporary-branch
 git branch -d temporary-branch
 git reset HEAD^

Obviously this only works for commits I haven't pushed yet, but it's very 
useful to be able to do - usually I need it because I missed a git-add of a 
file out of a commit and didn't notice for a while.

Once I'm happy with my local history, then I git-push to the shared repository 
and an email is generated to let other members of the team know I've done 
something - they can then git-fetch and review if they feel like it.

To me, sending an email every commit would be like sending an email every time 
I pressed "save" in the editor.



Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com

Re: Mail after commit

[Martin Langhoff]

On 6/14/07, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Wed, 2007-06-13 08:35:57 +1200, Martin Langhoff <martin.langhoff@gmail.com> wrote:
> > On 6/13/07, Claudio Scordino <cloud.of.andor@gmail.com> wrote:
> > > Doesn't exist any way to make it simpler ?
> >
> > I think most people setup gitweb, and follow its rss feed. Not exacty
> > the same, I know, but quite useful.
>
> Erm, no, not really.  Emailing the patches is *quite* useful when
> there's a dedicated review team.

I'm sure the review team can read the RSS feed ;-) I've also seen
RSS-to-IMAP gateways that make it easy to "reply" to the patch from
your MUA.

Not _exactly_ the same, but quite useful.


martin

Re: Mail after commit

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

On Thu, 2007-06-14 09:19:57 +1200, Martin Langhoff <martin.langhoff@gmail.com> wrote:
> On 6/14/07, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> > On Wed, 2007-06-13 08:35:57 +1200, Martin Langhoff > ><martin.langhoff@gmail.com> wrote:
> > > On 6/13/07, Claudio Scordino <cloud.of.andor@gmail.com> wrote:
> > > > Doesn't exist any way to make it simpler ?
> > >
> > > I think most people setup gitweb, and follow its rss feed. Not exacty
> > > the same, I know, but quite useful.
> >
> > Erm, no, not really.  Emailing the patches is *quite* useful when
> > there's a dedicated review team.
> 
> I'm sure the review team can read the RSS feed ;-) I've also seen
> RSS-to-IMAP gateways that make it easy to "reply" to the patch from
> your MUA.

Well, why import it to the mail platform via RSS when there's a direct
way:)  Almost all interesting patches require review (and commenting),
and we're working with the email client all the day. So it's just
straight forward ;-)

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:         "really soon now":      an unspecified period of time, likly to
the second  :                                 be greater than any reasonable definition
                                              of "soon".

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]