From: Johannes Sixt <J.Sixt@eudaptics.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Add a local implementation of hstrerror for the system which do not have it
Date: Wed, 13 Jun 2007 09:05:03 +0200 [thread overview]
Message-ID: <466F971F.C74761E2@eudaptics.com> (raw)
In-Reply-To: 20070612213129.GD2459@steel.home
Alex Riesen wrote:
> + static char buffer[32];
> ...
> + sprintf(buffer, "Name resolution error %d", err);
I don't think it's a problem for any current implementation, but it
would be better to err on the conservative side: The buffer should be at
least 44 chars wide to account for 20 digit negative numbers (thats the
maximum if int is 64 bits wide).
-- Hannes
next prev parent reply other threads:[~2007-06-13 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 16:13 [BUG] 75d8ff1 fails on SunOS 5.9 (missing hsterror) from ba505322 Randal L. Schwartz
2007-06-12 20:03 ` Alex Riesen
2007-06-12 20:52 ` [PATCH] Do not use h_errno after connect(2): the function does not set it Alex Riesen
2007-06-12 21:31 ` [PATCH] Add a local implementation of hstrerror for the system which do not have it Alex Riesen
2007-06-13 7:05 ` Johannes Sixt [this message]
[not found] ` <81b0412b0706130051l570e6ab7y48d6eea8c6b2d97e@mail.gmail.com>
2007-06-13 18:54 ` Alex Riesen
2007-06-16 15:21 ` Randal L. Schwartz
2007-06-18 21:28 ` Brandon Casey
2007-06-18 21:34 ` Brandon Casey
2007-06-18 21:37 ` Alex Riesen
2007-06-18 21:53 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466F971F.C74761E2@eudaptics.com \
--to=j.sixt@eudaptics.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).