From: Sam Vilain <sam@vilain.net>
To: Dave O'Neill <dmo@roaringpenguin.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Let git-svnimport clean up SVK commit messages.
Date: Thu, 21 Jun 2007 18:01:01 +1200 [thread overview]
Message-ID: <467A141D.1050502@vilain.net> (raw)
In-Reply-To: <1182392095394-git-send-email-dmo@roaringpenguin.com>
Dave O'Neill wrote:
> SVK likes to begin all commit messages with a line of the format:
> r12345@hostname: user | YYYY-MM-DD HH:MM:SS -ZZZZ
> which makes the import desperately ugly in git. This adds a -k option to move
> this extra SVK commit line to the end of the commit message, rather than
> keeping it at the beginning.
This is a good idea, of course if somebody didn't specify the magic -I
switch to their 'svk sm' incantation then there will be multiple changes
listed in a single revision
some examples
http://dev.catalystframework.org/svnweb/Catalyst/revision/?rev=6477
svn log -r 7190:7190 http://svn.pugscode.org/pugs
There was also a pretty nasty bug in SVK which pushed huge commitlogs
with no changes
see for example
http://utsl.gen.nz/gitweb/?p=pugs;a=commit;h=817b73f
(or:
svn log -r 14734:14734 http://svn.pugscode.org/pugs
svn diff -r 14733:14734 http://svn.pugscode.org/pugs
)
That occurred often enough that it might even be worth detecting and
dealing with specially. ie, if multiple SVK changesets are seen in a
commit with no changes, mark it as likely bogus.
Yeah, I'm not sure what to say about all this other than "lolsvn".
Sam.
next prev parent reply other threads:[~2007-06-21 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-21 2:14 [PATCH] Let git-svnimport clean up SVK commit messages Dave O'Neill
2007-06-21 3:19 ` Steven Grimm
2007-06-21 14:14 ` Dave O'Neill
2007-06-21 15:00 ` Jeffrey C. Ollie
2007-06-21 21:58 ` Dave O'Neill
2007-06-21 6:01 ` Sam Vilain [this message]
2007-06-21 14:22 ` Dave O'Neill
2007-06-21 20:51 ` [PATCH] Let git-svnimport and git-svn " Dave O'Neill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467A141D.1050502@vilain.net \
--to=sam@vilain.net \
--cc=dmo@roaringpenguin.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).