From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: David Kastrup <dak@gnu.org>, git@vger.kernel.org
Subject: Re: 100%
Date: Mon, 25 Jun 2007 00:23:23 +0200 [thread overview]
Message-ID: <467EEEDB.9030301@lsrfire.ath.cx> (raw)
In-Reply-To: <Pine.LNX.4.64.0706231318180.4059@racer.site>
Johannes Schindelin schrieb:
> Hi,
>
> On Sat, 23 Jun 2007, René Scharfe wrote:
>
>> As I already hinted at, the common result of comparing two files, as
>> done by e.g. cmp(1), is one bit that indicates equality. This
>> information is lost when using up/down rounding, but it is retained when
>> rounding down. It's _not_ common to be unable to determine equality
>> from the result of a file compare.
>
> And as _I_ already hinted, this does not matter. The whole purpose to have
> a number here instead of a bit is to have a larger range. In practice, I
> bet that the 100% are really uninteresting. At least here, they are.
You would lose your bet since both David and me expressed interest in
that pure 100% thing.
Rounding down instead of up/down doesn't affect the size of neither the
input nor the output range. It affects the boundary of the input range,
(-0.499 .. 100.499 versus 0.000 .. 100.999), but I can't find a problem
with that.
> For example, if you move a Java class from one package into another, you
> have to change the package name in the file. Guess what, I am perfectly
> okay if the rename detector says "100% similarity" here. Because if it is
> closer to 100% than to 99%, dammit, I want to see 100%, not 99%.
That uses a side effect of rounding and won't work for small files. And
of course (if the file is large enough) there could be other changes
"hidden" in a similarity index value of 100% that was rounded up.
> Nuff said about this subject.
Yes, let's advance this topic to the coding stage.
René
next prev parent reply other threads:[~2007-06-24 22:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-21 3:06 Basename matching during rename/copy detection Shawn O. Pearce
2007-06-21 3:13 ` Junio C Hamano
2007-06-21 8:00 ` Andy Parkins
2007-06-21 8:07 ` Junio C Hamano
2007-06-21 9:50 ` Andy Parkins
2007-06-21 11:52 ` Johannes Schindelin
2007-06-21 12:44 ` Andy Parkins
2007-06-21 12:53 ` Matthieu Moy
2007-06-21 13:10 ` Jeff King
2007-06-21 13:18 ` Johannes Schindelin
2007-06-21 13:25 ` Matthieu Moy
2007-06-21 13:52 ` Johannes Schindelin
2007-06-21 15:37 ` Steven Grimm
2007-06-21 15:53 ` Johannes Schindelin
2007-06-21 16:57 ` Steven Grimm
2007-06-21 13:22 ` Johannes Schindelin
2007-06-21 3:42 ` Linus Torvalds
2007-06-21 11:52 ` [PATCH] diffcore-rename: favour identical basenames Johannes Schindelin
2007-06-21 13:19 ` Jeff King
2007-06-21 14:03 ` Johannes Schindelin
2007-06-21 16:20 ` Linus Torvalds
2007-06-21 17:52 ` Junio C Hamano
2007-06-21 18:24 ` Linus Torvalds
2007-06-22 15:19 ` Andy Parkins
2007-06-22 15:28 ` Johannes Schindelin
2007-06-22 17:51 ` Aidan Van Dyk
2007-06-22 1:14 ` Johannes Schindelin
2007-06-22 5:41 ` Jeff King
2007-06-22 10:22 ` Johannes Schindelin
2007-06-22 7:17 ` Johannes Sixt
2007-06-22 10:39 ` Johannes Schindelin
2007-06-22 10:52 ` 100% (was: [PATCH] diffcore-rename: favour identical basenames) David Kastrup
2007-06-22 12:49 ` Johannes Schindelin
[not found] ` <86abusi1fw.fsf@lola.quinscape.zz>
2007-06-23 1:31 ` 100% Johannes Schindelin
2007-06-23 10:18 ` 100% René Scharfe
2007-06-23 10:56 ` 100% Johannes Schindelin
2007-06-23 11:41 ` 100% René Scharfe
2007-06-23 12:00 ` 100% Johannes Schindelin
2007-06-23 12:11 ` 100% René Scharfe
2007-06-23 12:21 ` 100% Johannes Schindelin
2007-06-24 22:23 ` René Scharfe [this message]
2007-06-23 19:33 ` 100% Junio C Hamano
2007-06-23 20:41 ` 100% Johannes Schindelin
2007-06-23 5:44 ` [PATCH] diffcore-rename: favour identical basenames Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467EEEDB.9030301@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=Johannes.Schindelin@gmx.de \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).