From: David Howells <dhowells@redhat.com>
To: Valerie Aurora <valerie.aurora@gmail.com>
Cc: dhowells@redhat.com, "git@vger.kernel.org" <git@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: How best to handle multiple-authorship commits in GIT?
Date: Fri, 03 Feb 2012 13:47:00 +0000 [thread overview]
Message-ID: <4681.1328276820@redhat.com> (raw)
In-Reply-To: <CAD-XujkVK=tOtmVS90U0KAutFZ55jxsHMKuuMppXOi-H6ZY=RQ@mail.gmail.com>
Valerie Aurora <valerie.aurora@gmail.com> wrote:
> And for a complete (meaningful) rewrite such as David has done, he
> changes the commit authorship and adds a Signed-off-by for the
> original author.
Val[*] hasn't signed off all her patches, and indeed I've merged together some
patches that she has signed off and some she hasn't. I can't simply add
Signed-off-by her without her permission. However, if she's willing for me to
add such lines, then I can do so.
> Signed-off-by: Some Upstream Author
> Signed-off-by: Maintainer or Merger (rewrote error handling)
And if the changes are more than can be put in what's left of the line? I
would've thought it would make more sense to do something like:
Signed-off-by: Valerie Aurora <valerie.aurora@gmail.com> (Original author)
Signed-off-by: David Howells <dhowells@redhat.com> (Further development)
David
[*] Apologies for talking about/to you in the third person, Val.
next prev parent reply other threads:[~2012-02-03 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 12:25 How best to handle multiple-authorship commits in GIT? David Howells
2012-02-02 13:41 ` Frans Klaver
2012-02-02 18:00 ` Valerie Aurora
2012-02-02 19:57 ` Jakub Narebski
2012-02-02 18:36 ` David Howells
2012-02-03 2:18 ` Valerie Aurora
2012-02-03 5:11 ` Junio C Hamano
2012-02-03 13:47 ` David Howells [this message]
2012-02-03 18:27 ` Junio C Hamano
2012-02-03 19:49 ` Valerie Aurora
2012-02-02 20:33 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4681.1328276820@redhat.com \
--to=dhowells@redhat.com \
--cc=git@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=valerie.aurora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).