Re: [PATCH] git-log: detect dup and fdopen failure

[Josh Triplett <josh@freedesktop.org>]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Linus Torvalds wrote:
> On Wed, 27 Jun 2007, Jim Meyering wrote:
>> Subject: [PATCH] git-log: detect dup and fdopen failure
>>  git-compat-util.h (xdup, xfdopen): Define functions.
>>
>> Signed-off-by: Jim Meyering <jim@meyering.net>
> 
> Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
> 
> That said, the whole "prepend 'x' to the function name" thing is obviously 
> how git does things, but maybe it would be more readable in the long term 
> to make the prefix be 'safe_' instead of 'x', or something like that?

If you want a more verbose name than xfoo, I personally like the foo_or_die
convention, which reminds you explicitly that the function might kill the
program.  safe_ might convey exactly the opposite impression.

- Josh Triplett


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]