From: Michael J Gruber <git@drmicha.warpmail.net>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCHv3 1/3] cvsimport: partial whitespace cleanup
Date: Wed, 1 Dec 2010 13:53:20 +0100 [thread overview]
Message-ID: <468f815beeede312f98daa66986ce8bf887724b3.1291207768.git.git@drmicha.warpmail.net> (raw)
In-Reply-To: <7vd3pmw9n5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <cover.1291207768.git.git@drmicha.warpmail.net>
in preparation of the config parse patch
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
git-cvsimport.perl | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index d27abfe..7888b77 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -91,8 +91,8 @@ sub write_author_info($) {
# convert getopts specs for use by git config
sub read_repo_config {
- # Split the string between characters, unless there is a ':'
- # So "abc:de" becomes ["a", "b", "c:", "d", "e"]
+ # Split the string between characters, unless there is a ':'
+ # So "abc:de" becomes ["a", "b", "c:", "d", "e"]
my @opts = split(/ *(?!:)/, shift);
foreach my $o (@opts) {
my $key = $o;
@@ -100,13 +100,13 @@ sub read_repo_config {
my $arg = 'git config';
$arg .= ' --bool' if ($o !~ /:$/);
- chomp(my $tmp = `$arg --get cvsimport.$key`);
+ chomp(my $tmp = `$arg --get cvsimport.$key`);
if ($tmp && !($arg =~ /--bool/ && $tmp eq 'false')) {
- no strict 'refs';
- my $opt_name = "opt_" . $key;
- if (!$$opt_name) {
- $$opt_name = $tmp;
- }
+ no strict 'refs';
+ my $opt_name = "opt_" . $key;
+ if (!$$opt_name) {
+ $$opt_name = $tmp;
+ }
}
}
}
--
1.7.3.2.617.g84f63
next prev parent reply other threads:[~2010-12-01 12:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 15:10 [PATCH 1/3] cvsimport: partial whitespace cleanup Michael J Gruber
2010-11-25 15:10 ` [PATCH 2/3] cvsimport: fix the parsing of uppercase config options Michael J Gruber
2010-11-27 6:38 ` Junio C Hamano
2010-11-28 19:30 ` Michael J Gruber
2010-11-28 19:39 ` [PATCHv2 1/3] cvsimport: partial whitespace cleanup Michael J Gruber
2010-11-28 19:39 ` [PATCHv2 2/3] cvsimport: fix the parsing of uppercase config options Michael J Gruber
2010-11-28 19:39 ` [PATCHv2 3/3] cvsimport.txt: document the mapping between config and options Michael J Gruber
2010-11-29 20:23 ` Junio C Hamano
2010-11-30 7:56 ` Michael J Gruber
2010-12-01 1:43 ` Junio C Hamano
2010-12-01 12:53 ` [PATCHv3 0/3] uppercase config options for cvsimport Michael J Gruber
2010-12-01 12:53 ` Michael J Gruber [this message]
2010-12-01 12:53 ` [PATCHv3 2/3] cvsimport: fix the parsing of uppercase config options Michael J Gruber
2010-12-01 14:59 ` Martin Langhoff
2010-12-01 16:05 ` Jonathan Nieder
2010-12-01 16:18 ` Martin Langhoff
2010-12-01 16:23 ` Jakub Narebski
2010-12-01 16:34 ` Jonathan Nieder
2010-12-01 16:52 ` Michael J Gruber
2010-12-01 17:01 ` Jonathan Nieder
2010-12-01 17:58 ` Jeff King
2010-12-01 19:47 ` Junio C Hamano
2010-12-02 21:46 ` Junio C Hamano
2010-12-01 17:55 ` Jeff King
2010-12-01 18:36 ` [PATCH] add: introduce add.ignoreerrors synonym for add.ignore-errors Jonathan Nieder
2010-12-01 18:46 ` Jeff King
2010-12-01 18:57 ` Jonathan Nieder
2010-12-01 19:56 ` Junio C Hamano
2010-12-01 20:09 ` Junio C Hamano
2010-12-01 21:07 ` Jeff King
2010-12-03 2:18 ` Junio C Hamano
2010-12-01 12:53 ` [PATCHv3 3/3] cvsimport.txt: document the mapping between config and options Michael J Gruber
2010-12-01 15:02 ` [PATCHv2 " Martin Langhoff
2010-12-01 15:34 ` Michael J Gruber
2010-11-25 15:10 ` [PATCH " Michael J Gruber
2010-11-27 6:33 ` [PATCH 1/3] cvsimport: partial whitespace cleanup Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468f815beeede312f98daa66986ce8bf887724b3.1291207768.git.git@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).