git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Rica <jasampler@gmail.com>
To: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Sven Verdoolaege <skimo@liacs.nl>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH] t7004: Skip tests for signed tags in an old version of gpg.
Date: Sun, 08 Jul 2007 21:36:34 +0200	[thread overview]
Message-ID: <46913CC2.4030101@gmail.com> (raw)

As said here: http://www.gnupg.org/documentation/faqs.html#q6.19
the gpg version 1.0.6 didn't parse trust packets correctly, so for
that version, creation of signed tags using the generated key fails.

Signed-off-by: Carlos Rica <jasampler@gmail.com>
---
This was already discussed in a previous message from Sven,
who runs that old version of gpg:
http://thread.gmane.org/gmane.comp.version-control.git/51291

The page describing the bug was found by Johannes after some research:
http://colabti.de/irclogger/irclogger_log/git?date=2007-07-01,Sun&sel=482#l814

 t/t7004-tag.sh |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index a845930..b785080 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -460,6 +460,17 @@ if [ $? -eq 127 ]; then
 	exit
 fi

+# As said here: http://www.gnupg.org/documentation/faqs.html#q6.19
+# the gpg version 1.0.6 didn't parse trust packets correctly, so for
+# that version, creation of signed tags using the generated key fails.
+case "$(gpg --version)" in
+'gpg (GnuPG) 1.0.6'*)
+	echo "Skipping signed tag tests, because a bug in 1.0.6 version"
+	test_done
+	exit
+	;;
+esac
+
 # key generation info: gpg --homedir t/t7004 --gen-key
 # Type DSA and Elgamal, size 2048 bits, no expiration date.
 # Name and email: C O Mitter <committer@example.com>
-- 
1.5.0

             reply	other threads:[~2007-07-08 19:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-08 19:36 Carlos Rica [this message]
2007-07-08 20:22 ` [PATCH] t7004: Skip tests for signed tags in an old version of gpg Sven Verdoolaege
2007-07-08 21:56   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46913CC2.4030101@gmail.com \
    --to=jasampler@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=skimo@liacs.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).