Recent issues

Recent issues

[Junio C Hamano]

Here is a list of recent issues on the list that I am aware of,
but not much have been done on.

To use the Message-ID, you can use:

    http://mid.gmane.org/$message_id

where $message_id is the Message-ID without surrounding <>.

* gitweb patches (bunch of them)

  From: Matt McCutchen <hashproduct@gmail.com>
  Subject: [PATCH] gitweb: snapshot cleanups & support for offering multiple formats
  Message-ID: <1183053733.6108.0.camel@mattlaptop2>

  From: Matt McCutchen <hashproduct@gmail.com>
  Subject: [PATCH] gitweb: make search form generate pathinfo-style URLs
  Message-ID: <1183057027.6108.4.camel@mattlaptop2>

  From: Matt McCutchen <hashproduct@gmail.com>
  Subject: [PATCH] gitweb: make "No commits" in project list gray, not bold green
  Message-ID: <1183068922.6108.8.camel@mattlaptop2>

  From: Miklos Vajna <vmiklos@frugalware.org>
  Subject: [PATCH] gitweb: prefer git_get_project_owner() over get_file_owner()
  Message-ID: <20070703221122.GI32766@genesis.frugalware.org>

  From: Michael Hendricks <michael@ndrix.org>
  Subject: [PATCH] gitweb: configurable width for the projects list Description column
  Message-ID: <11835958082458-git-send-email-michael@ndrix.org>

Haven't heard any from gitweb folks about these; I'd take a look
at them if I find time this weekend.

* gitk --left-right

  From: Linus Torvalds <torvalds@linux-foundation.org>
  Message-ID: <alpine.LFD.0.98.0705051524300.17381@woody.linux-foundation.org>
  From: Junio C Hamano <junkio@cox.net>
  Message-ID: <7vabwifl23.fsf@assigned-by-dhcp.cox.net>

Paulus?

* gitk tree view fix

  From: Brian Downing <bdowning@lavos.net>
  Subject: [PATCH] gitk: Fix for tree view ending in nested directories
  Message-ID: <20070704212643.GR4087@lavos.net>

Paulus?

* switching branches when b changes between symlink and directory in a/b/c

  From: Pierre Habouzit <madcoder@debian.org>
  Subject: [BUG (or misfeature?)] git checkout and symlinks
  Message-ID: <20070704203541.GA13286@artemis.corp>

Will take a look.

* cherry-pick unexpected conflicts

  From: Gerrit Pape <pape@smarden.org>
  Subject: Re: unexpected git-cherry-pick conflict
  Message-ID: <20070613134336.13661.qmail@c61f4fed932273.315fe32.mid.smarden.org>

* git-apply -R --whitespace=warn

  From: Daniel Barkalow <barkalow@iabervon.org>
  Message-ID: <Pine.LNX.4.64.0707062155170.6977@iabervon.org>
  Subject: Minor bug in git-apply's patch-cleaning

* Use gitattributes for more things.

 - Customized "diff -p" markers per path.

  From: Linus Torvalds <torvalds@linux-foundation.org>
  Subject: Re: [PATCH] Per-path attribute based hunk header selection.
  Message-ID: <alpine.LFD.0.98.0707061051020.9434@woody.linux-foundation.org>

Will take a look and try to finish this before 1.5.3-rc1.

Re: Recent issues

[Paul Mackerras]

Junio C Hamano writes:

> * gitk --left-right
> 
>   From: Linus Torvalds <torvalds@linux-foundation.org>
>   Message-ID: <alpine.LFD.0.98.0705051524300.17381@woody.linux-foundation.org>
>   From: Junio C Hamano <junkio@cox.net>
>   Message-ID: <7vabwifl23.fsf@assigned-by-dhcp.cox.net>
> 
> Paulus?

Looks mostly OK; I assume there's no possible downside to using git
log -v --pretty=raw rather than git rev-list?

Also, in the second patch, commitside needs to either be indexed by
view as well as id, or needs to be "context-switched" by showview.
I'll fix it.  Since neither you nor Linus included a signed-off-by,
I'll combine the patches and fix up a few things.

> * gitk tree view fix
> 
>   From: Brian Downing <bdowning@lavos.net>
>   Subject: [PATCH] gitk: Fix for tree view ending in nested directories
>   Message-ID: <20070704212643.GR4087@lavos.net>
> 
> Paulus?

Looks reasonable.

Paul.

Re: Recent issues

[Johannes Sixt]

Paul Mackerras wrote:
> 
> Junio C Hamano writes:
> 
> > * gitk --left-right
> >
> >   From: Linus Torvalds <torvalds@linux-foundation.org>
> >   Message-ID: <alpine.LFD.0.98.0705051524300.17381@woody.linux-foundation.org>
> >   From: Junio C Hamano <junkio@cox.net>
> >   Message-ID: <7vabwifl23.fsf@assigned-by-dhcp.cox.net>
> >
> > Paulus?
> 
> Looks mostly OK; I assume there's no possible downside to using git
> log -v --pretty=raw rather than git rev-list?

In general, there is a big down-side, although I don't know if this
particular case is affected: --pretty=raw prints the parents noted in
the commit object, but not those from .git/info/grafts.

-- Hannes

Re: Recent issues

[Johannes Sixt]

Paul Mackerras wrote:
> 
> Johannes Sixt writes:
> 
> > In general, there is a big down-side, although I don't know if this
> > particular case is affected: --pretty=raw prints the parents noted in
> > the commit object, but not those from .git/info/grafts.
> 
> Are you referring to the parents listed on the "commit" line when you
> have the --parents flag, or the parents listed on "parent" lines in
> the commit?  Gitk uses the former, and I hope that does in fact
> reflect grafts.  It certainly reflects the "logical" topology when
> using path limiting.

It seems that git log --parents --pretty=raw prints the "logical" parent
in the "commit" line, i.e. the grafted parent, but the real parent in
the "parent" lines.

Since gitk uses the "commit" line, all is well. Please ignore my
comment.

-- Hannes