From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] Make fetch-pack a builtin with an internal API
Date: Mon, 09 Jul 2007 20:04:35 +0200 [thread overview]
Message-ID: <469278B3.40905@lsrfire.ath.cx> (raw)
In-Reply-To: <Pine.LNX.4.64.0707090142130.6977@iabervon.org>
Daniel Barkalow schrieb:
> On Sun, 8 Jul 2007, Junio C Hamano wrote:
>
>> Are _identifiers with leading underscore Kosher thing to do, I
>> wonder... We do have ones with trailing ones (mostly qsort
>> functions) and I think they are done that way for the sake of
>> standards conformance.
>
> I'm not sure; I inherited that bit of code from Julian. Do we have a
> standard idiom for a function that sets a bunch of static variables?
You could put all flags and settings into a struct fetch_pack_args.
You could then go one step further by exporting the struct definition
and letting the internal interface take a pointer to such a struct,
thereby getting rid of static variables and their setup routine.
René
next prev parent reply other threads:[~2007-07-09 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 5:10 [PATCH v2] Make fetch-pack a builtin with an internal API Daniel Barkalow
2007-07-09 5:39 ` Junio C Hamano
2007-07-09 6:37 ` Daniel Barkalow
2007-07-09 18:04 ` René Scharfe [this message]
2007-07-09 18:16 ` Daniel Barkalow
2007-07-09 11:50 ` Theodore Tso
2007-07-09 13:16 ` Andy Parkins
2007-07-09 14:40 ` Theodore Tso
2007-07-09 15:10 ` Florian Weimer
2007-07-09 15:28 ` Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469278B3.40905@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).